Review main Merged

22741[TASK] Use magic __CLASS__ in getInstance()-methods

Stefan Neufeind CR +2 V +2 Easy +5 −5 updated 08/06/13, 17:23

Commit message

Some classes contain static getInstance()-methods that return
an instance of themselves. Instead of using the correct namespace
and classname everywhere, just use __CLASS__.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Dmitry Dulepov +2
  • Verified V +2
    • Wouter Wolters +2
    • Dmitry Dulepov +2

Issues 1

Files 4

Review log 5

  1. Mr. Jenkins commented on patch set 1 08/01/13, 01:25

  2. Stefan Neufeind commented on patch set 1 08/01/13, 01:35

    CategoryRegistry.php:50

    could we also use __CLASS_ for the return? We'd need to check with phpdoc and typical IDEs. But I guess that might lead to problems
  3. Dmitry Dulepov commented on patch set 1 V +2 CR +2 08/02/13, 09:07

    Could not find any issues while testing.
  4. Wouter Wolters voted on patch set 1 V +2 CR +2 08/06/13, 17:23

  5. Wouter Wolters merged patch set 2 08/06/13, 17:23