Review main Merged

22789[BUGFIX] Fix empty href parameter

Anja Leichsenring CR +2 V +2 Normal +71 −3 updated 08/05/13, 21:01

Commit message

In case the link target is not available (maybe hidden), the behaviour
known from the Core is to render the link text, but no a tag. The pageVH
renders the link, but the href parameter will be empty.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 2

Review log 16

  1. Mr. Jenkins commented on patch set 1 08/03/13, 13:43

  2. Stefan Neufeind commented on patch set 1 CR +1 08/03/13, 15:59

    looks pretty obvious

    PageViewHelper.php:4

    We dohn't usually indent this imho, but leave an empty line below this block.
  3. Anja Leichsenring uploaded patch set 2 08/04/13, 06:16

  4. Mr. Jenkins commented on patch set 2 08/04/13, 06:17

  5. Stefan Neufeind commented on patch set 2 CR +1 08/04/13, 11:15

    only one newline-nitpick, sorry. But rest makes sense by reading.

    PageViewHelper.php:74

    Sorry, I must have overseen this previously: To my knowledge phpdoc might have problems with this newline - all @something afaik should be one block
  6. Anja Leichsenring uploaded patch set 3 08/04/13, 18:00

  7. Mr. Jenkins commented on patch set 3 08/04/13, 18:01

  8. Anja Leichsenring uploaded patch set 4 08/04/13, 19:18

  9. Mr. Jenkins commented on patch set 4 08/04/13, 19:18

  10. Stefan Neufeind commented on patch set 4 V +1 CR +1 08/04/13, 22:20

    thanks for the tests
  11. Wouter Wolters uploaded patch set 5 08/05/13, 20:59

  12. Mr. Jenkins commented on patch set 5 08/05/13, 21:00

  13. Wouter Wolters commented on patch set 5 V +2 CR +2 08/05/13, 21:00

    No technical changes in last commit. Only added a class comment and removed an empty line from the test.
  14. Wouter Wolters merged patch set 6 08/05/13, 21:00

  15. Wouter Wolters commented on patch set 6 08/05/13, 21:00

    Cherry Picked This patchset was cherry picked to change: I526aa0e3d42f8aba867b3f996bac2366dc1f6d19
  16. Wouter Wolters commented on patch set 6 08/05/13, 21:01

    Cherry Picked This patchset was cherry picked to change: I526aa0e3d42f8aba867b3f996bac2366dc1f6d19