22789[BUGFIX] Fix empty href parameter
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
-
Verified V +2
- Wouter Wolters +2
Issues 1
Files 2
Review log 16
-
Mr. Jenkins commented on patch set 1 08/03/13, 13:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9882/ : SUCCESS -
Stefan Neufeind commented on patch set 1 CR +1 08/03/13, 15:59
looks pretty obviousPageViewHelper.php:4We dohn't usually indent this imho, but leave an empty line below this block. -
Anja Leichsenring uploaded patch set 2 08/04/13, 06:16
-
Mr. Jenkins commented on patch set 2 08/04/13, 06:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9888/ : SUCCESS -
Stefan Neufeind commented on patch set 2 CR +1 08/04/13, 11:15
only one newline-nitpick, sorry. But rest makes sense by reading.PageViewHelper.php:74Sorry, I must have overseen this previously: To my knowledge phpdoc might have problems with this newline - all @something afaik should be one block -
Anja Leichsenring uploaded patch set 3 08/04/13, 18:00
-
Mr. Jenkins commented on patch set 3 08/04/13, 18:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9890/ : SUCCESS -
Anja Leichsenring uploaded patch set 4 08/04/13, 19:18
-
Mr. Jenkins commented on patch set 4 08/04/13, 19:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9891/ : SUCCESS -
Stefan Neufeind commented on patch set 4 V +1 CR +1 08/04/13, 22:20
thanks for the tests -
Wouter Wolters uploaded patch set 5 08/05/13, 20:59
-
Mr. Jenkins commented on patch set 5 08/05/13, 21:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9907/ : SUCCESS -
Wouter Wolters commented on patch set 5 V +2 CR +2 08/05/13, 21:00
No technical changes in last commit. Only added a class comment and removed an empty line from the test. -
Wouter Wolters merged patch set 6 08/05/13, 21:00
-
Wouter Wolters commented on patch set 6 08/05/13, 21:00
Cherry Picked This patchset was cherry picked to change: I526aa0e3d42f8aba867b3f996bac2366dc1f6d19 -
Wouter Wolters commented on patch set 6 08/05/13, 21:01
Cherry Picked This patchset was cherry picked to change: I526aa0e3d42f8aba867b3f996bac2366dc1f6d19