Review TYPO3_4-5 Merged

2279[BUGFIX] Flexform sheet description should be editable via TSConfig

Steffen Gebert CR +2 V +2 Easy +21 −4 updated 06/03/13, 20:49

Commit message

Flexform sheet description, short description and language meta settings are now editable via TSConfig.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 06/24/11, 11:28

    Verified; Looks good to me, but someone else must approve
  2. Steffen Gebert commented on patch set 1 06/24/11, 11:28

    (1 inline comment) See my inline comment. Otherwise perfect.

    class.t3lib_tceforms_flexforms.php:105

    Why are these lines required and what do they do? If it requires some explanation, maybe add an additional comment. Not clear to me (and it also works without them).
  3. Steffen Gebert commented on patch set 1 V 0 06/24/11, 11:28

    by team member; Looks good to me, approved
  4. Philipp Gampe commented on patch set 1 06/24/11, 11:28

    Verified; Looks good to me, but someone else must approve
  5. Kai Richter commented on patch set 1 06/24/11, 11:28

    Verified; Looks good to me, but someone else must approve

    class.t3lib_tceforms_flexforms.php:105 Reply

    Flexforms have a build in possibility to use different field settings for multiple languages. As you can read here the handling of this multi-language behavior is configurable in the meta part of a Flexform: http://typo3.org/documentation/document-library/core-documentation/doc_core_api/4.1.0/view/4/2/#id4244259 (Search for "langDisable"). This modification allow the configuration of the language handling afterwards.
  6. Kai Richter commented on patch set 1 06/24/11, 11:28

    (1 inline comment)
  7. Mr. Jenkins commented on patch set 1 06/24/11, 11:28

  8. Steffen Gebert merged patch set 1 06/24/11, 11:28