2279[BUGFIX] Flexform sheet description should be editable via TSConfig
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Stefan Neufeind +1
- Philipp Gampe +1
-
Verified V +2
- Steffen Gebert +2
- Stefan Neufeind +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 8
-
Stefan Neufeind commented on patch set 1 06/24/11, 11:28
Verified; Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 1 06/24/11, 11:28
(1 inline comment) See my inline comment. Otherwise perfect.class.t3lib_tceforms_flexforms.php:105Why are these lines required and what do they do? If it requires some explanation, maybe add an additional comment. Not clear to me (and it also works without them). -
Steffen Gebert commented on patch set 1 V 0 06/24/11, 11:28
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 1 06/24/11, 11:28
Verified; Looks good to me, but someone else must approve -
Kai Richter commented on patch set 1 06/24/11, 11:28
Verified; Looks good to me, but someone else must approveclass.t3lib_tceforms_flexforms.php:105ReplyFlexforms have a build in possibility to use different field settings for multiple languages. As you can read here the handling of this multi-language behavior is configurable in the meta part of a Flexform: http://typo3.org/documentation/document-library/core-documentation/doc_core_api/4.1.0/view/4/2/#id4244259 (Search for "langDisable"). This modification allow the configuration of the language handling afterwards. -
Kai Richter commented on patch set 1 06/24/11, 11:28
(1 inline comment) -
Mr. Jenkins commented on patch set 1 06/24/11, 11:28
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/109/ : SUCCESS -
Steffen Gebert merged patch set 1 06/24/11, 11:28