Review TYPO3_4-4 Merged

2282[BUGFIX] pageNotFound_handling error with relative paths

Markus Klein CR +2 V +2 Easy +5 −1 updated 06/03/13, 20:49

Commit message

This patch fixes the handling of relative paths of pageNotFound_handling.
Due to a missing check, the relative path is prefixed with http_host only,
causing a wrong Location header.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
  • Verified V +2
    • Andreas Wolf +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 6

  1. Andreas Wolf commented on patch set 2 06/06/11, 15:04

    Pushing this as it works for master and there is no change between the two branches which could be relevant for this patch.
  2. Stefan Neufeind commented on patch set 2 06/06/11, 15:04

    Verified; Looks good to me, but someone else must approve
  3. Markus Klein uploaded patch set 2 06/06/11, 15:04

  4. Kurt Kunig commented on patch set 1 06/06/11, 15:04

    Verified; Looks good to me, but someone else must approve have some differences in the line-numbers?!
  5. Andreas Wolf commented on patch set 2 V 0 06/06/11, 15:04

    by team member; Looks good to me, approved Pushing this as it works for master and there is no change between the two branches which could be relevant for this patch.
  6. Andreas Wolf merged patch set 2 06/06/11, 15:04