Review TYPO3_6-1 Merged

22831[BUGFIX] Fatal error: "enableFields on non-object" in extension manager

Stefan Neufeind CR +2 V +2 Easy +2 −2 updated 08/06/13, 12:30

Commit message

Don't rely on $TSFE object to detect if we are in a frontend context. Rely
on TYPO3_MODE constant instead.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2

Issues 1

Files 1

Review log 5

  1. Stefan Neufeind commented on patch set 1 08/05/13, 20:49

    Cherry Picked This patchset was cherry picked to change: I06ea2692dab7683c7284e5f3ff45036d72c64999
  2. Stefan Neufeind commented on patch set 1 08/05/13, 20:50

    straight. Let's wait 24 hours or so maybe if everyone is fine with the hotfix merged in master.
  3. Anja Leichsenring commented on patch set 1 V -1 08/06/13, 09:24

    breaks the tests
  4. Anja Leichsenring commented on patch set 1 V +2 CR +2 08/06/13, 12:30

    this breaks the tests, but fix comes right after with https://review.typo3.org/#q,I7319d8ccef530feff69a7f9885df24dba0beed4d,n,z
  5. Anja Leichsenring merged patch set 2 08/06/13, 12:30