22836[BUGFIX] Fix failing test in StorageRepositoryTest
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Anja Leichsenring +1
- Ernesto Baschny +1
-
Verified V +2
- Nicole Hummel +2
- Anja Leichsenring +1
- Ernesto Baschny +1
Issues 1
Files 2
Review log 28
Show 3 earlier messages
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 08/06/13, 08:30
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/9909/ : FAILURE -
Anja Leichsenring uploaded patch set 2 08/06/13, 08:39
-
Mr. Jenkins commented on patch set 2 08/06/13, 08:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9910/ : SUCCESS
-
Anja Leichsenring updated the commit message in patch set 2 08/06/13, 09:00
-
Mr. Jenkins commented on patch set 3 08/06/13, 09:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9911/ : SUCCESS -
Oliver Klee commented on patch set 3 08/06/13, 09:06
StorageRepository.php:208@param is missing In addition, I'd prefer to have a setter (or only getter that can be mocked) for this constant. This would be cleaner than having this as a method parameter. -
Anja Leichsenring commented on patch set 3 08/06/13, 09:19
StorageRepository.php:208ReplyI like to avoid the even more intrusive usage of a class variable. With the missing annotation I am with you and will push an update. -
Nicole Hummel uploaded patch set 4 08/06/13, 11:21
-
Mr. Jenkins commented on patch set 4 08/06/13, 11:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9914/ : SUCCESS -
Nicole Hummel commented on patch set 4 08/06/13, 11:22
I refactored the mode setting in an own function. This is useful for upcoming changes which needs different code for FE and BE -
Anja Leichsenring commented on patch set 4 08/06/13, 11:26
StorageRepository.php:208the parameter is not needed anymore with the getter in Place -
Oliver Klee commented on patch set 4 08/06/13, 11:28
StorageRepository.php:225I'd prefer more information: @return string either "FE", "BE" or "CLI" -
Nicole Hummel uploaded patch set 5 08/06/13, 11:35
-
Mr. Jenkins commented on patch set 5 08/06/13, 11:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9915/ : SUCCESS -
Anja Leichsenring commented on patch set 5 08/06/13, 11:36
StorageRepositoryTest.php:69remove it here as well please -
Nicole Hummel uploaded patch set 6 08/06/13, 11:37
-
Mr. Jenkins commented on patch set 6 08/06/13, 11:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9916/ : SUCCESS -
Anja Leichsenring voted on patch set 6 V +1 CR +1 08/06/13, 11:45
-
Anja Leichsenring updated the commit message in patch set 6 08/06/13, 11:47
-
Anja Leichsenring voted on patch set 7 V +1 CR +1 08/06/13, 11:47
-
Mr. Jenkins commented on patch set 7 08/06/13, 11:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9917/ : SUCCESS -
Ernesto Baschny uploaded patch set 8 08/06/13, 12:14
-
Ernesto Baschny commented on patch set 8 V +1 CR +1 08/06/13, 12:14
I've just updated the commit message. Works -
Mr. Jenkins commented on patch set 8 08/06/13, 12:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9918/ : SUCCESS -
Anja Leichsenring voted on patch set 8 V +1 CR +1 08/06/13, 12:18
-
Nicole Hummel voted on patch set 8 V +2 CR +2 08/06/13, 12:18
-
Nicole Hummel merged patch set 9 08/06/13, 12:18
-
Anja Leichsenring commented on patch set 9 08/06/13, 12:33
Cherry Picked This patchset was cherry picked to change: I7319d8ccef530feff69a7f9885df24dba0beed4d