Review main Merged

22836[BUGFIX] Fix failing test in StorageRepositoryTest

Anja Leichsenring CR +2 V +2 Easy +13 −2 updated 08/06/13, 12:33

Commit message

With #50803 the usage of the constant TYPO3_MODE was introduced. This
leads to the failing test, after the constant can not be redefined
for test purposes.

To work around this, a method that can be mocked is introduced, and
specifically set to "FE" for this test to work again.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Anja Leichsenring +1
    • Ernesto Baschny +1
  • Verified V +2
    • Nicole Hummel +2
    • Anja Leichsenring +1
    • Ernesto Baschny +1

Issues 1

Files 2

Review log 28

Show 3 earlier messages
  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 08/06/13, 08:30

  2. Anja Leichsenring uploaded patch set 2 08/06/13, 08:39

  3. Mr. Jenkins commented on patch set 2 08/06/13, 08:40

  1. Anja Leichsenring updated the commit message in patch set 2 08/06/13, 09:00

  2. Mr. Jenkins commented on patch set 3 08/06/13, 09:01

  3. Oliver Klee commented on patch set 3 08/06/13, 09:06

    StorageRepository.php:208

    @param is missing In addition, I'd prefer to have a setter (or only getter that can be mocked) for this constant. This would be cleaner than having this as a method parameter.
  4. Anja Leichsenring commented on patch set 3 08/06/13, 09:19

    StorageRepository.php:208 Reply

    I like to avoid the even more intrusive usage of a class variable. With the missing annotation I am with you and will push an update.
  5. Nicole Hummel uploaded patch set 4 08/06/13, 11:21

  6. Mr. Jenkins commented on patch set 4 08/06/13, 11:21

  7. Nicole Hummel commented on patch set 4 08/06/13, 11:22

    I refactored the mode setting in an own function. This is useful for upcoming changes which needs different code for FE and BE
  8. Anja Leichsenring commented on patch set 4 08/06/13, 11:26

    StorageRepository.php:208

    the parameter is not needed anymore with the getter in Place
  9. Oliver Klee commented on patch set 4 08/06/13, 11:28

    StorageRepository.php:225

    I'd prefer more information: @return string either "FE", "BE" or "CLI"
  10. Nicole Hummel uploaded patch set 5 08/06/13, 11:35

  11. Mr. Jenkins commented on patch set 5 08/06/13, 11:35

  12. Anja Leichsenring commented on patch set 5 08/06/13, 11:36

    StorageRepositoryTest.php:69

    remove it here as well please
  13. Nicole Hummel uploaded patch set 6 08/06/13, 11:37

  14. Mr. Jenkins commented on patch set 6 08/06/13, 11:38

  15. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/06/13, 11:45

  16. Anja Leichsenring updated the commit message in patch set 6 08/06/13, 11:47

  17. Anja Leichsenring voted on patch set 7 V +1 CR +1 08/06/13, 11:47

  18. Mr. Jenkins commented on patch set 7 08/06/13, 11:47

  19. Ernesto Baschny uploaded patch set 8 08/06/13, 12:14

  20. Ernesto Baschny commented on patch set 8 V +1 CR +1 08/06/13, 12:14

    I've just updated the commit message. Works
  21. Mr. Jenkins commented on patch set 8 08/06/13, 12:14

  22. Anja Leichsenring voted on patch set 8 V +1 CR +1 08/06/13, 12:18

  23. Nicole Hummel voted on patch set 8 V +2 CR +2 08/06/13, 12:18

  24. Nicole Hummel merged patch set 9 08/06/13, 12:18

  25. Anja Leichsenring commented on patch set 9 08/06/13, 12:33

    Cherry Picked This patchset was cherry picked to change: I7319d8ccef530feff69a7f9885df24dba0beed4d