Review main Merged

22838[BUGFIX] Backup singletons in unit tests prior to other setUp operations

Nicole Hummel CR +2 V +2 Easy +9 −8 updated 08/06/13, 22:38

Commit message

If the singleton management is changed in unit tests, a local copy of
the previous stage is done to re-construct this state in tearDown().
This has to be done before any other instantiation in setUp() is
initiated which might register additional singletons.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • Nicole Hummel +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • Nicole Hummel +1

Issues 1

Files 6

Review log 15

  1. Mr. Jenkins commented on patch set 1 08/06/13, 10:25

  2. Christian Kuhn commented on patch set 1 08/06/13, 19:18

    definatly not back-portable to < 6.0
  3. Christian Kuhn voted on patch set 1 CR -1 08/06/13, 19:24

  4. Christian Kuhn uploaded patch set 2 08/06/13, 19:29

  5. Mr. Jenkins commented on patch set 2 08/06/13, 19:29

  6. Christian Kuhn commented on patch set 2 V +1 CR +1 08/06/13, 19:29

    Rewording the commit message.
  7. Christian Kuhn commented on patch set 2 CR -1 08/06/13, 19:31

    Fatal error: Class 'TYPO3\CMS\Form\Domain\Factory\TypoScriptFactory' not found in /var/www/src/typo3_src-git/master/typo3/sysext/form/Tests/Unit/Domain/Factory/TypoScriptFactoryTest.php on line 41
  8. Christian Kuhn voted on patch set 2 V -1 CR 0 08/06/13, 19:31

  9. Christian Kuhn commented on patch set 2 08/06/13, 19:34

    ah sry, my fail ... testing again ...
  10. Christian Kuhn voted on patch set 2 V 0 08/06/13, 19:34

  11. Nicole Hummel voted on patch set 2 V +1 CR +1 08/06/13, 19:37

  12. Christian Kuhn voted on patch set 2 V +1 CR +1 08/06/13, 19:38

  13. Stefan Neufeind commented on patch set 2 V +2 CR +2 08/06/13, 22:38

    Didn't experience the errors Nicole pointed to before this patch. But with the patch tests run fine for me and given the explanation the change makes sense.
  14. Stefan Neufeind merged patch set 3 08/06/13, 22:38

  15. Stefan Neufeind commented on patch set 3 08/06/13, 22:38

    Cherry Picked This patchset was cherry picked to change: I7788a5788aca6777040b777aeceb0558f96022b2