22838[BUGFIX] Backup singletons in unit tests prior to other setUp operations
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Christian Kuhn +1
- Nicole Hummel +1
-
Verified V +2
- Stefan Neufeind +2
- Christian Kuhn +1
- Nicole Hummel +1
Issues 1
Files 6
- typo3/sysext/core/Tests/Functional/Utility/File/ExtendedFileUtilityTest.php+3 −2
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/ExtensionMangementUtilityTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/View/StandaloneViewTest.php+1 −1
Review log 15
-
Mr. Jenkins commented on patch set 1 08/06/13, 10:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9913/ : SUCCESS -
Christian Kuhn commented on patch set 1 08/06/13, 19:18
definatly not back-portable to < 6.0 -
Christian Kuhn voted on patch set 1 CR -1 08/06/13, 19:24
-
Christian Kuhn uploaded patch set 2 08/06/13, 19:29
-
Mr. Jenkins commented on patch set 2 08/06/13, 19:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9928/ : SUCCESS -
Christian Kuhn commented on patch set 2 V +1 CR +1 08/06/13, 19:29
Rewording the commit message. -
Christian Kuhn commented on patch set 2 CR -1 08/06/13, 19:31
Fatal error: Class 'TYPO3\CMS\Form\Domain\Factory\TypoScriptFactory' not found in /var/www/src/typo3_src-git/master/typo3/sysext/form/Tests/Unit/Domain/Factory/TypoScriptFactoryTest.php on line 41 -
Christian Kuhn voted on patch set 2 V -1 CR 0 08/06/13, 19:31
-
Christian Kuhn commented on patch set 2 08/06/13, 19:34
ah sry, my fail ... testing again ... -
Christian Kuhn voted on patch set 2 V 0 08/06/13, 19:34
-
Nicole Hummel voted on patch set 2 V +1 CR +1 08/06/13, 19:37
-
Christian Kuhn voted on patch set 2 V +1 CR +1 08/06/13, 19:38
-
Stefan Neufeind commented on patch set 2 V +2 CR +2 08/06/13, 22:38
Didn't experience the errors Nicole pointed to before this patch. But with the patch tests run fine for me and given the explanation the change makes sense. -
Stefan Neufeind merged patch set 3 08/06/13, 22:38
-
Stefan Neufeind commented on patch set 3 08/06/13, 22:38
Cherry Picked This patchset was cherry picked to change: I7788a5788aca6777040b777aeceb0558f96022b2