Review main Merged

22840[BUGFIX] Use proper implementation of a wordwrap

Georg Ringer CR +2 V +2 Easy +7 −2 updated 08/06/13, 18:49

Commit message

The page module uses a custom implementation of a wordwrap
as this was not supported by the browser in those earlier days.

The big drawback is that there is no UTF8 support for this which
leads to empty preview boxes when e.g. using Japanese.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 14

  1. Mr. Jenkins commented on patch set 1 08/06/13, 12:21

  2. Susi Moog commented on patch set 1 CR +1 08/06/13, 12:22

    PageLayoutView.php:1696

    missing )
  3. Georg Ringer uploaded patch set 2 08/06/13, 15:16

  4. Mr. Jenkins commented on patch set 2 08/06/13, 15:17

  5. Christian Kuhn commented on patch set 2 CR -1 08/06/13, 17:22

    PageLayoutView.php:1699

    Why not keep the implementation until its dropped and only mark is at deprecated?
  6. Christian Kuhn uploaded patch set 3 08/06/13, 17:25

  7. Mr. Jenkins commented on patch set 3 08/06/13, 17:25

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/06/13, 17:33

  9. Christian Kuhn commented on patch set 3 08/06/13, 17:38

    Could anyone please test cross-browser functionality? Reproduce: Add a text content element, add the example string from the ticket to RTE, save, call page view: no text before change but some wrapped text after change.
  10. Wouter Wolters uploaded patch set 4 08/06/13, 18:37

  11. Wouter Wolters commented on patch set 4 V +1 CR +1 08/06/13, 18:38

    Checked in IE7 to IE10, Chrome and FF
  12. Mr. Jenkins commented on patch set 4 08/06/13, 18:38

  13. Christian Kuhn commented on patch set 4 V +2 CR +2 08/06/13, 18:49

    also works in (younger) opera.
  14. Christian Kuhn merged patch set 5 08/06/13, 18:49