Review main Merged

22896[BUGFIX] Test in Configuration\ConfigurationManagerTest fails in backend

Nicole Hummel CR +2 V +2 Easy +3 −3 updated 08/06/13, 22:27

Commit message

When running the tests in the PHPUnit backend, the path of the current
working directory is typo3/ (where mod.php is included). Therefore the
test canWriteConfigurationReturnsTrueIfDirectoryAndFilesAreWritable
fails as it deals with paths relative to the root directory. We have to
use absolute paths to ensure files in typo3temp folder exist.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Jigal van Hemert +1
  • Verified V +2
    • Stefan Neufeind +2
    • Jigal van Hemert +1

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 08/06/13, 20:55

  2. Nicole Hummel uploaded patch set 2 08/06/13, 20:57

  3. Nicole Hummel commented on patch set 2 08/06/13, 20:58

    Removed wrong dependency
  4. Mr. Jenkins commented on patch set 2 08/06/13, 20:58

  5. Jigal van Hemert commented on patch set 2 V +1 CR +1 08/06/13, 21:33

    Green again on Vista / PHP 5.4
  6. Stefan Neufeind voted on patch set 2 V +2 CR +2 08/06/13, 22:07

  7. Stefan Neufeind merged patch set 3 08/06/13, 22:07

  8. Wouter Wolters commented on patch set 3 08/06/13, 22:07

    Post review +1
  9. Stefan Neufeind commented on patch set 3 08/06/13, 22:27

    Cherry Picked This patchset was cherry picked to change: I7859978c31cf523c8803316fdac8c067d00042cc