Review main Merged

22918[BUGFIX] Tests in Localization\Parser\LocallangXmlParserTest fail

Nicole Hummel CR +2 V +2 Easy +17 −17 updated 08/27/13, 09:07

Commit message

If the system is already translated into French two tests in
Localization\Parser\LocallangXmlParserTest fail. This is because another
localization file is taken where test strings are not included.

As the tested functions can't work system independent, the test has to
make sure no system dependencies are used. Therefore the patch
introduces a new language "md5" to prove the workflow.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 15

  1. Mr. Jenkins commented on patch set 1 08/07/13, 11:29

  2. Nicole Hummel commented on patch set 1 CR -2 08/07/13, 11:37

    Under review again
  3. Nicole Hummel uploaded patch set 2 08/07/13, 12:16

  4. Mr. Jenkins commented on patch set 2 08/07/13, 12:17

  5. Nicole Hummel voted on patch set 2 CR 0 08/07/13, 12:31

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 08/07/13, 17:41

  7. Nicole Hummel uploaded patch set 3 08/26/13, 20:04

  8. Mr. Jenkins commented on patch set 3 08/26/13, 20:05

  9. Nicole Hummel commented on patch set 3 08/26/13, 20:05

    Removed the change to the original LocallangXmlParser
  10. Christian Kuhn voted on patch set 3 CR +1 08/26/13, 20:22

  11. Christian Kuhn voted on patch set 3 V +1 08/26/13, 20:36

  12. Stefan Neufeind voted on patch set 3 V +2 CR +2 08/27/13, 09:07

  13. Stefan Neufeind merged patch set 4 08/27/13, 09:07

  14. Stefan Neufeind commented on patch set 4 08/27/13, 09:07

    Cherry Picked This patchset was cherry picked to change: I64e8864a7d746c4f5c278f5e67d8dae068d8f920
  15. Stefan Neufeind commented on patch set 4 08/27/13, 09:07

    Cherry Picked This patchset was cherry picked to change: I64e8864a7d746c4f5c278f5e67d8dae068d8f920