22923[BUGFIX] Files with unclean path indexed multiple times
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Wouter Wolters +1
- Helmut Hummel +1
-
Verified V +2
- Stefan Neufeind +2
- Wouter Wolters +1
- Helmut Hummel +1
Files 6
- typo3/sysext/core/Classes/Resource/Driver/AbstractHierarchicalFilesystemDriver.php2+4 −2
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+2 −4
- typo3/sysext/core/Classes/Resource/ResourceStorage.php2+1 −0
- typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php6+9 −8
- typo3/sysext/core/Classes/Utility/PathUtility.php2+100 −1
- typo3/sysext/core/Tests/Unit/Utility/PathUtilityTest.php4+118 −0
Review log 24
-
Mr. Jenkins commented on patch set 1 08/07/13, 12:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9947/ : SUCCESS -
Jigal van Hemert commented on patch set 1 08/08/13, 09:18
A few questions/doubts.BasicFileUtility.php:30Why is this removed (see also next comment) No use for PathUitility?BasicFileUtility.php:135If the use statement is removed, this won't work anymore. -
Steffen Ritter commented on patch set 1 08/08/13, 09:20
right, seems to be a cherry-picking/merging error... -
Steffen Ritter uploaded patch set 2 08/11/13, 17:43
-
Mr. Jenkins commented on patch set 2 08/11/13, 17:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10004/ : SUCCESS -
Steffen Ritter uploaded patch set 3 08/11/13, 17:44
-
Mr. Jenkins commented on patch set 3 08/11/13, 17:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10005/ : SUCCESS -
Helmut Hummel commented on patch set 3 08/15/13, 09:53
AbstractHierarchicalFilesystemDriver.php:45I think we should keep that for better testabilityResourceStorage.php:217What do we need that for?BasicFileUtility.php:174Why did you change that?BasicFileUtility.php:202Same here?PathUtility.php:209Should we call this normalize<Foo> instead of clean<Foo> to make clear this is not a security related method? "clean" may be understood as "safe" -
Helmut Hummel commented on patch set 3 CR -1 08/20/13, 14:45
working on an update... -
Stefan Neufeind commented on patch set 3 08/20/13, 16:36
@Helmut: thanks for taking a look and following up on this patchAbstractHierarchicalFilesystemDriver.php:45Replyif I remember right we originally had it still in, then discussed and decided we don't need it anymore. But yes, we can have it.ResourceStorage.php:217Replylooks like a leftover now. Maybe also from porting a previous patch or soBasicFileUtility.php:174Replynot intentional. Must have been ported over from an older patch, reverting a replacement meanwhile done inbetween.BasicFileUtility.php:202Replysame here :-)PathUtility.php:209ReplyFine with me. "clean" was a bit meant with "security" in mind ... well, creating absolute paths and not going above top-level etc. But normalize is fine as well. -
Helmut Hummel uploaded patch set 4 08/20/13, 16:50
-
Mr. Jenkins commented on patch set 4 08/20/13, 16:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10162/ : SUCCESS -
Helmut Hummel commented on patch set 4 V -1 CR -1 08/20/13, 16:51
There is still an error -
Helmut Hummel uploaded patch set 5 08/20/13, 17:06
-
Mr. Jenkins commented on patch set 5 08/20/13, 17:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10163/ : SUCCESS -
Stefan Neufeind commented on patch set 5 08/20/13, 17:14
Well done, Helmut. Thanks a lot.PathUtilityTest.php:305use __NAMESPACE__ (testing-namespace) herePathUtilityTest.php:312then here as well -
Wouter Wolters commented on patch set 5 V +1 CR +1 08/20/13, 17:17
All unit-tests are green on my side. -
Helmut Hummel uploaded patch set 6 08/20/13, 17:28
-
Helmut Hummel voted on patch set 6 V +1 CR +1 08/20/13, 17:29
-
Helmut Hummel commented on patch set 5 08/20/13, 17:29
PathUtilityTest.php:305ReplyDonePathUtilityTest.php:312ReplyDone -
Mr. Jenkins commented on patch set 6 08/20/13, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10164/ : SUCCESS -
Wouter Wolters voted on patch set 6 V +1 CR +1 08/20/13, 17:34
-
Stefan Neufeind voted on patch set 6 V +2 CR +2 08/20/13, 19:56
-
Stefan Neufeind merged patch set 7 08/20/13, 19:56