Review main Merged

22934[BUGFIX] Faulty expand/collapse behavior in Element Browser

Oliver Hader CR +2 V +2 Normal +72 −8 updated 01/06/19, 11:15

Commit message

On using the element browser in combination with files, the
expand/collapse behavior is wrong. On opening a collapsed folder,
an AJAX call fetches the sub-nodes that will be added to the DOM
tree. However, the calling scope of the original rendering
process and the AJAX call differ a lot.
The only possibility to get this working is to transfer the
scope and rebuild it in the AJAX context.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +2
    • Henrik Ziegenhain +1
    • Markus Schubath +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +2
    • Henrik Ziegenhain +1
    • Markus Schubath +1

Files 4

Review log 8

  1. Mr. Jenkins commented on patch set 1 08/07/13, 17:04

  2. Helmut Hummel updated the commit message in patch set 1 09/07/13, 09:02

  3. Mr. Jenkins commented on patch set 2 09/07/13, 09:03

  4. Markus Schubath voted on patch set 2 V +1 CR +1 09/13/13, 06:08

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 09/17/13, 17:36

  6. Anja Leichsenring commented on patch set 2 V +2 CR +2 09/17/13, 17:46

    good catch and nice fix. Works for me now, thanks.
  7. Anja Leichsenring merged patch set 3 09/17/13, 17:46

  8. Henrik Ziegenhain commented on patch set 2 V +1 CR +1 01/06/19, 11:15

    Solves the described problem. Does no one besides me have this issue, or why here are no reviews?