Review main Merged

22936[BUGFIX] number_format() expects parameter 1 to be double

Wouter Wolters CR +2 V +2 Easy +8 −1 updated 08/08/13, 20:40

Commit message

In stdWrap function numberFormat $content is a string.
Make sure this is a float value when it is passed into
PHP function number_format.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 11

  1. Mr. Jenkins commented on patch set 1 08/07/13, 17:50

  2. Christian Kuhn updated the commit message in patch set 1 08/08/13, 20:06

  3. Mr. Jenkins commented on patch set 2 08/08/13, 20:08

  4. Christian Kuhn updated the commit message in patch set 2 08/08/13, 20:12

  5. Mr. Jenkins commented on patch set 3 08/08/13, 20:13

  6. Christian Kuhn commented on patch set 3 08/08/13, 20:15

    I'd merge this to 4.7 & 4.5 as well since it can heavily flood the syslog, this is imho sort of "critical" fix that shouldn't harm, it should be safe to backport to those versions, too.
  7. Christian Kuhn voted on patch set 3 V +1 CR +1 08/08/13, 20:15

  8. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/08/13, 20:27

  9. Anja Leichsenring merged patch set 4 08/08/13, 20:27

  10. Anja Leichsenring commented on patch set 4 08/08/13, 20:35

    Cherry Picked This patchset was cherry picked to change: If4a98ae8238264f94f771c997fbe6cac98311912
  11. Anja Leichsenring commented on patch set 4 08/08/13, 20:40

    Cherry Picked This patchset was cherry picked to change: If4a98ae8238264f94f771c997fbe6cac98311912