Review main Merged

23019[TASK] Visual feedback on hover: spot text links

Felix Kopp CR +2 V +2 Easy +5 −0 updated 08/12/13, 16:41

Commit message

Text links are not spotted easily. Give TYPO3 an easy visual feedback
for text links on hover. Hover on table rows also pumps up text links.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 08/10/13, 11:16

  2. Wouter Wolters commented on patch set 1 CR -1 08/10/13, 11:50

    main_content.css:65

    this gives trouble. Check for example Backend Users module and hover on one of the icons, now you have multiple black lines next to the icons..
  3. Felix Kopp commented on patch set 1 08/10/13, 11:58

    main_content.css:65 Reply

    'A' tags with spaces and excessive padding need to be improved. The backend is not optimal here ofter <a>Icon Text</a> has been done. Here the solution must be <a>Icon</a> <a>Text</a> :( Should this change already bring these changes or follow-up?
  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/12/13, 11:15

  5. Wouter Wolters voted on patch set 1 V +2 CR +2 08/12/13, 16:41

  6. Wouter Wolters merged patch set 2 08/12/13, 16:41