Review main Merged

23058[BUGFIX] Filename not displayed in selector (file_reference)

Martin Borer CR +2 V +2 Easy +5 −3 updated 09/08/13, 13:12

Commit message

The selector values in BE-fields with type group->file_reference are
empty. The filename should be displayed at this place.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Steffen Ritter +1
    • Frans Saris +1
  • Verified V +2
    • Wouter Wolters +2
    • Steffen Ritter +1
    • Frans Saris +1

Issues 1

Files 2

Review log 25

  1. Mr. Jenkins commented on patch set 1 08/12/13, 10:24

  2. Wouter Wolters updated the commit message in patch set 1 08/12/13, 17:30

  3. Wouter Wolters voted on patch set 2 V +1 CR +1 08/12/13, 17:30

  4. Mr. Jenkins commented on patch set 2 08/12/13, 17:31

  5. Philipp Gampe commented on patch set 2 CR -1 08/17/13, 16:50

    I cannot reproduce this on current master. Can you test this again? 'config' => array( 'type' => 'group', 'internal_type' => 'file_reference', 'uploadfolder' => 'fileadmin/user_upload/', 'allowed' => 'jpg,gif,png', 'disallowed' => 'php', 'size' => 1, 'maxitems' => 1, 'minitems' => 0, ),
  6. Wouter Wolters commented on patch set 2 08/17/13, 17:02

    Please check the test extension from Forge
  7. Philipp Gampe commented on patch set 2 08/17/13, 17:08

    there is no test extension at forge? Or am I blind?
  8. Martin Borer commented on patch set 2 08/19/13, 08:22

    Hi Philipp, The issue is still there in current master, just tested it. I think Wouter thought about a test extension in an other Ticket: http://forge.typo3.org/issues/49538 this extension demonstrates also an other issue with internal type file_reference, but you can use it to test this issue here..
  9. Martin Borer commented on patch set 2 08/21/13, 08:40

    @Philipp are you still not able to reproduce this? Does it depends on OS? I've tested it on Windows 7 with XAMPP 1.8.1
  10. Martin Borer commented on patch set 2 08/27/13, 16:19

    Some love for this tiny little bugfix would be great! ;) It resolves an annoying behavior if you are using group->file_reference in TCA.
  11. Philipp Gampe commented on patch set 2 CR 0 09/02/13, 22:33

    I added an screenshot to the issue... anyway, I remove my -1. If you can reproduce it ... you can fix it ;)
  12. Martin Borer commented on patch set 2 09/03/13, 08:27

    Hi Philipp, That's interessting!.. I still don't have the values in the selectors of file_reference fields. Just tested in 6.1, not able to get 6.2 working at the moment (installer is in a loop during installation) :( It looks like this solution here is only a 'dirty' trick. Maybe the main issue is on an other place and depends on OS/Browser?!? What's your testing environment? Ohh and selecting PHP files should not work! looks like an other issue..
  13. Philipp Gampe commented on patch set 2 09/03/13, 17:45

    I use Fedora 19: master, PHP 5.5.3, Chrome. The file extension filter seems to work inverse ... will test this again.
  14. Martin Borer commented on patch set 2 09/04/13, 15:13

    I've did some additional tests: - debian wheezy | php 5.4.4 | Typo3 master - windows | php 5.5.3 | Typo3 master - mac | php 5.4.4 | Typo3 6.1 no filename in selectors for file_reference fields.. :( Do we have to do some more investigations about this? Or is it ok to merge this patch like it is now?
  15. Steffen Ritter commented on patch set 2 09/04/13, 15:18

    Will have a look at it on the weekend, anyhow see my comment which needs to be fixed anyhow to not fail with umlauts in file name.

    FormEngine.php:3687

    Must PathUtility::basename()
  16. Steffen Ritter voted on patch set 2 CR -1 09/04/13, 15:18

  17. Martin Borer uploaded patch set 3 09/05/13, 21:38

  18. Mr. Jenkins commented on patch set 3 09/05/13, 21:38

  19. Martin Borer updated the commit message in patch set 3 09/05/13, 21:39

  20. Mr. Jenkins commented on patch set 4 09/05/13, 21:40

  21. Martin Borer commented on patch set 4 09/05/13, 21:54

    The core of the problem is more in the DataPreprocessor than in FormEngine. In the function renderRecord_groupProc the internal_type check for file_reference was missing. I've also moved the basename part to this function, which makes more sense to me. @Philipp.. still have no idea, why it was working on your fedora environment. :(
  22. Steffen Ritter commented on patch set 4 V +1 CR +1 09/07/13, 07:13

    I am able to reproduce on current master, new patch set looks straight forward and works for me. As we are only changing a rendering preProcess part "a little bit" I don't expect side affects.
  23. Frans Saris voted on patch set 4 V +1 CR +1 09/08/13, 11:44

  24. Wouter Wolters voted on patch set 4 V +2 CR +2 09/08/13, 13:12

  25. Wouter Wolters merged patch set 5 09/08/13, 13:12