23183[BUGFIX] FlashMessageQueue PHP strict warning
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Helmut Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Helmut Hummel +1
Issues 1
Files 1
Review log 20
-
Mr. Jenkins commented on patch set 1 08/18/13, 13:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10136/ : SUCCESS -
Helmut Hummel updated the commit message in patch set 1 08/18/13, 14:00
-
Mr. Jenkins commented on patch set 2 08/18/13, 14:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10137/ : SUCCESS -
Philipp Gampe voted on patch set 2 CR +1 08/18/13, 14:09
-
Helmut Hummel commented on patch set 2 08/19/13, 08:46
FlashMessageQueue.php:62I would include the given type in the exception -
Wouter Wolters uploaded patch set 3 08/20/13, 17:40
-
Mr. Jenkins commented on patch set 3 08/20/13, 17:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10165/ : SUCCESS -
Wouter Wolters commented on patch set 3 V +1 CR +1 08/20/13, 17:41
Exception now looks like: #1376833554: enqueue() expects an object of type \TYPO3\CMS\Core\Messaging\FlashMessage but is of type "stdClass" -
Helmut Hummel uploaded patch set 4 08/20/13, 17:49
-
Helmut Hummel voted on patch set 4 V +1 CR +1 08/20/13, 17:50
-
Mr. Jenkins commented on patch set 4 08/20/13, 17:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10166/ : SUCCESS -
Helmut Hummel uploaded patch set 5 08/20/13, 17:56
-
Helmut Hummel voted on patch set 5 V +1 CR +1 08/20/13, 17:57
-
Mr. Jenkins commented on patch set 5 08/20/13, 17:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10167/ : SUCCESS -
Helmut Hummel uploaded patch set 6 08/20/13, 17:58
-
Mr. Jenkins commented on patch set 6 08/20/13, 17:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10168/ : SUCCESS -
Helmut Hummel voted on patch set 6 V +1 CR +1 08/20/13, 17:59
-
Wouter Wolters voted on patch set 6 V +2 CR +2 08/20/13, 17:59
-
Wouter Wolters merged patch set 7 08/20/13, 17:59
-
Wouter Wolters commented on patch set 7 08/20/13, 18:00
Cherry Picked This patchset was cherry picked to change: I882aab33a55d84de6614a45c6cc045223adba0cd