Review TYPO3_6-1 Merged

23197[BUGFIX] FlashMessageQueue PHP strict warning

Wouter Wolters CR +2 V +2 Easy +8 −2 updated 08/20/13, 18:10

Commit message

FlashMessageQueue exends \SplQueue and overwrites enqueue($value).
In \SplQueue enqueue() has no type hint on $value, but
FlashMessageQueue adds a type hint to FlashMessage. This raises
a PHP strict warning.

Solution is to remove the type hint and add an exception instead
if given argument is not an instance of FlashMessage.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 2

  1. Wouter Wolters voted on patch set 1 V +2 CR +2 08/20/13, 18:10

  2. Wouter Wolters merged patch set 2 08/20/13, 18:10