23205[FEATURE] Autodetection for integrated charset-conversions
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 7
-
Mr. Jenkins commented on patch set 1 08/20/13, 21:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10170/ : SUCCESS -
Wouter Wolters commented on patch set 1 08/20/13, 21:32
Great to have a check for this but why not introduce this into the upcoming autocofiguration from Christian? Now you are checking it on every call which is not good IMO -
Stefan Neufeind commented on patch set 1 08/20/13, 22:00
I was/am not aware of upcoming changes by Christian. Maybe he could comment on this. The checks inside the function were already there before. The autodetection is just done "once" upon construction of the object. Not creating new objects over and over is of cause a good idea anyway. Maybe we could make the converter a singleton so makeInstance returns one central instance? But that's not really the point here imho ... -
Christian Kuhn commented on patch set 1 CR -1 08/21/13, 08:37
Yeah, the charset settings are one of the first things to be done in the "configuration" section of the install tool. Take a look at catharsis, there is already some kickstarted code. -
Stefan Neufeind abandoned the change 08/21/13, 09:00
@Christian: Then do as you please. I abandoned this one now and don't care any further. I've just had a SLOW master on a testing-install and it turned out it was using the homemade php-stuff. But if you have a solution, I look forward for you to commit it. -
Stefan Neufeind commented on patch set 1 10/29/13, 12:15
@Christian: There wasn't anything like this added so far, or am I wrong? -
Wouter Wolters commented on patch set 1 10/29/13, 12:47
There is a preset feature inside the Install Tool for this;-)