Review main Merged

2322[FEATURE] Make table labels for import static clickable

Markus Klein CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

An extension that provides static data shows up in the extension manager
with a list of checkboxes for each table to import.
The table names are not clickable, one has to target the tiny checkbox.

This fix adds the missing <label> tags around the table names.

Thanks to Christian Weiske for providing this patch.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Christian Weiske +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Christian Weiske +1

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 2 06/04/11, 05:20

    Verified; Looks good to me, but someone else must approve
  2. Markus Klein uploaded patch set 2 06/04/11, 05:20

  3. Christian Weiske commented on patch set 2 06/04/11, 05:20

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 06/04/11, 05:20

  5. Mr. Jenkins commented on patch set 2 06/04/11, 05:20

  6. Georg Ringer commented on patch set 2 V 0 06/04/11, 05:20

    by team member; Looks good to me, approved nobrainer
  7. Georg Ringer merged patch set 2 06/04/11, 05:20