Review main Merged

23227[BUGFIX] Fix menu popup for all IE versions

Alexander Opitz CR +2 V +2 Easy +3 −1 updated 11/11/13, 20:15

Commit message

The IE has problems with base URLs in JS on window.open()
function calls. This problem was already fixed for content
objects but not for the menu.

This change adds the baseUrlWrap and also the quoteJSvalue
function call like in ContentObjectRenderer::typoLink().

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Philipp Gampe +1
  • Verified V +2
    • Wouter Wolters +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 18

  1. Mr. Jenkins commented on patch set 1 08/21/13, 15:17

  2. Stefan Neufeind voted on patch set 1 CR +1 08/28/13, 11:36

  3. Philipp Gampe commented on patch set 1 CR -1 08/31/13, 19:41

    will push an update in a minute

    AbstractMenuContentObject.php:1325

    quoteJSvalue does not have a second parameter (no TRUE). Also it already adds the quotes for the content.
  4. Philipp Gampe uploaded patch set 2 08/31/13, 19:41

  5. Mr. Jenkins commented on patch set 2 08/31/13, 19:42

  6. Philipp Gampe commented on patch set 2 V +1 CR +1 08/31/13, 19:42

    I tested in Chrome and IE8. However I did not reproduce faulty behavior as I do not have a baseUrl setup. Anyway, the absolute URL works in both browsers.
  7. Stefan Neufeind commented on patch set 2 V -1 CR +1 08/31/13, 22:04

    Change looks okay. And it also still works after applying the patch (so that would make verified +1). But I failed to reproduce the problem without the patch, neither with IE8 nor IE7. I used base-url with TYPO3 inside a subdirectory, and used realurl to get multiple path-segments in the menu-link-url as well. Worked without the patch for me. Sorry, unable to reproduce though I tried hard.
  8. Alexander Opitz commented on patch set 2 09/01/13, 19:15

    @Stefan Did you try popups?
  9. Stefan Neufeind commented on patch set 2 09/01/13, 19:41

    of course I tried popups, just giving a width/height. They popped up as planned.
  10. Alexander Opitz commented on patch set 2 09/01/13, 19:45

    @Stefan Hmmm, so can you please send me the source you got without the patch? As the issue is a known bug in IE.
  11. Alexander Opitz commented on patch set 2 09/01/13, 19:48

    @Stefan And by the way, did you try it on http://domain/ or on a subpage like http://domain/my/page/ ?
  12. Alexander Opitz commented on patch set 2 09/12/13, 07:11

    @Stefan Please can you answer my last question?
  13. Alexander Opitz commented on patch set 2 10/11/13, 15:54

    @Stefan: Please answer my question or remove your -1
  14. Stefan Neufeind commented on patch set 2 V 0 10/12/13, 01:42

    I tried both directly below a domain and also below a subdirectory of a domain. It didn't work for me, no matter how I tried. But to not prevent others from testing this themselves, I herewith remove my -1. Please find somebody to test this carefully.
  15. Wouter Wolters voted on patch set 2 V +2 CR +2 11/11/13, 20:15

  16. Wouter Wolters merged patch set 3 11/11/13, 20:15

  17. Wouter Wolters commented on patch set 3 11/11/13, 20:15

    Cherry Picked This patchset was cherry picked to change: Ia1ad859d2acb358378bc4ffa3f6a9162b3fc6937
  18. Wouter Wolters commented on patch set 3 11/11/13, 20:15

    Cherry Picked This patchset was cherry picked to change: Ia1ad859d2acb358378bc4ffa3f6a9162b3fc6937