Review main Merged

23246[TASK] Merge pagegen.php to index_ts.php

Christian Kuhn CR +2 V +2 Normal +23 −57 updated 08/22/13, 19:00

Commit message

pagegen.php contains rendering code and is called twice
in index_ts.php. The patch merged the content of this
file to index_ts.php to have all global code in one file.

The patch is a straight forward refactoring, only the
time tracking is a bit simplified and an obsolete if
is removed at the former second inclusion of the file.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1

Issues 1

Files 2

Review log 4

  1. Mr. Jenkins commented on patch set 1 08/22/13, 10:44

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/22/13, 18:19

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 08/22/13, 19:00

  4. Wouter Wolters merged patch set 2 08/22/13, 19:00