23267[TASK] Use array access instead of traversing hook array
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Oliver Klee +1
- Helmut Hummel +1
- Philipp Gampe +1
-
Verified V +2
- Markus Klein +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 26
Show 1 earlier messages
-
Mr. Jenkins commented on patch set 1 08/23/13, 08:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10204/ : SUCCESS
-
Philipp Gampe voted on patch set 1 CR +1 08/23/13, 12:18
-
Wouter Wolters voted on patch set 1 CR +1 11/24/13, 21:39
-
Wouter Wolters wrote 11/24/13, 21:39
Topic set to "performance". -
Frans Saris commented on patch set 1 11/24/13, 22:23
ContentObjectRenderer.php:734Doesn't this give a warning when the array key $name doesn't exist? -
Jo Hasenau uploaded patch set 2 11/25/13, 15:29
-
Jo Hasenau commented on patch set 2 11/25/13, 15:30
Added a check for an existing array key and moved the declaration of the hookObj out of the if clause. -
Mr. Jenkins commented on patch set 2 11/25/13, 15:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12316/ : SUCCESS -
Frans Saris commented on patch set 2 11/25/13, 16:04
ContentObjectRenderer.php:735Maybe use !isEmpty($this->cObjHookObjectsArr[$name]) then you can drop the if($hookObj && -
Markus Klein commented on patch set 2 11/25/13, 16:19
ContentObjectRenderer.php:735Reply+1 for Frans' suggestion. -1 for CGL: missing space after if -
Jo Hasenau uploaded patch set 3 11/25/13, 16:32
-
Jo Hasenau commented on patch set 2 11/25/13, 16:33
ContentObjectRenderer.php:735ReplyDoneContentObjectRenderer.php:735ReplyDone -
Mr. Jenkins commented on patch set 3 11/25/13, 16:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12317/ : SUCCESS -
Frans Saris voted on patch set 3 CR +1 11/25/13, 17:16
-
Markus Klein voted on patch set 3 CR +1 11/25/13, 17:37
-
Philipp Gampe voted on patch set 3 CR +1 11/26/13, 11:40
-
Helmut Hummel commented on patch set 3 V -1 CR -1 11/26/13, 12:03
ContentObjectRenderer.php:735what is "isEmpty"? -
Jo Hasenau uploaded patch set 4 11/26/13, 13:19
-
Jo Hasenau commented on patch set 4 11/26/13, 13:20
I definitely do too many things with TypoScript ;-) At least PHP Storm did not complain about isEmpty though. -
Oliver Klee voted on patch set 4 CR +1 11/26/13, 13:29
-
Mr. Jenkins commented on patch set 4 11/26/13, 13:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12335/ : SUCCESS -
Philipp Gampe voted on patch set 4 V +1 CR +1 11/26/13, 14:46
-
Markus Klein voted on patch set 4 CR +1 11/26/13, 15:54
-
Helmut Hummel voted on patch set 4 CR +1 11/26/13, 16:48
-
Markus Klein voted on patch set 4 V +2 CR +2 11/28/13, 23:53
-
Markus Klein merged patch set 5 11/28/13, 23:53