Review TYPO3_6-0 Abandoned

23292[FEATURE] Find best-matching local storage instead of default-storage

Martin Borer CR 0 V 0 Hard +288 −29 updated 09/04/13, 11:10

Commit message

If no storage-UID is given usually the default-storage will be
used ("legacy-storage"). Some problems with not up-to-date
index-records etc. can be prevented by using a matching storage
instead of falling back to the default-storage (ID 0).

Implement search for best matching storage.

Resolves: #45498
Releases: 6.0

Conflicts:
	typo3/sysext/core/Classes/Resource/ResourceFactory.php
	typo3/sysext/core/Tests/Unit/Resource/FactoryTest.php

Review

  • Code review CR 0
  • Verified V 0

Files 3

Review log 4

  1. Martin Borer commented on patch set 1 08/24/13, 22:23

    This is a backport for 6.0. Reason for backporting this feature is to keep FAL in sync within the branches as far as possible. Request of this backport was approved by 6.1 and 6.0 Release Managers (see Typo3 Core list).
  2. Helmut Hummel commented on patch set 1 CR -2 09/03/13, 14:09

    Please abandon this change I pushed correct versions instead
    all releases should be specified
    Must be removed.
    Same change ID as master commit shall be used

    FactoryTest.php:2

    This is not a new file, but is named ResourceFactoryTest.php
  3. Helmut Hummel commented on patch set 1 09/03/13, 14:39

  4. Martin Borer abandoned the change 09/04/13, 11:10

    Wrong Change-Id New commit: https://review.typo3.org/23557