Review main Abandoned

23309[BUGFIX] Call stdWrapPostProcess hook even if "if" returned FALSE

Reinhard Führicht CR 0 V 0 Easy +7 −0 updated 03/30/15, 23:27

Commit message

When using "if" in TypoScript having a condition which returns FALSE,
the stdWrapPostProcess hook is not called. Change that.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 08/26/13, 09:03

  2. Wouter Wolters uploaded patch set 2 08/27/13, 18:41

  3. Wouter Wolters commented on patch set 2 CR +1 08/27/13, 18:42

    Fixed a CGL issue in the code. Space after elseif
  4. Mr. Jenkins commented on patch set 2 08/27/13, 18:42

  5. Markus Klein updated the commit message in patch set 3 08/28/14, 00:30

  6. Markus Klein commented on patch set 3 08/28/14, 00:30

    Needs a rebase
  7. Markus Klein uploaded patch set 4 12/01/14, 10:20

  8. Markus Klein voted on patch set 4 CR +1 12/01/14, 10:20

  9. Susi Moog commented on patch set 4 CR +1 V +1 12/16/14, 11:58

    Tested with formhandler and the example from the bug report.
  10. Markus Klein commented on patch set 4 CR -1 V -1 12/16/14, 12:29

    This is a breaking change. The hook is now called after: stdWrap_cacheRead, stdWrap_fieldRequired, stdWrap_if and stdWrap_required If somebody is using this hook there will more calls to the hook now. The $content passed to the hook might be unexpected as well. IMHO this can go into master only and needs [!!!] and rst-file

    ContentObjectRenderer.php:2197

    Why this workaround with $functionName??
  11. Mathias Schreiber wrote 12/17/14, 20:36

    Topic set to cObj
  12. Markus Klein abandoned the change 03/30/15, 23:27

    No action since a long time and a breaking change.