Review main Merged

23356[TASK] Shorten database names in functional tests

Sascha Egerer CR +2 V +2 Easy +14 −2 updated 08/27/13, 13:09

Commit message

The functional tests frameworks create a new database per test.
The database name is generated by the original database
name plus a string and a hash.

If the database name length exceeds the maximum length of 64
characters an exception is now thrown.

The generated database name is also been shortened a bit.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 08/27/13, 11:18

  2. Stefan Neufeind commented on patch set 1 CR +1 08/27/13, 12:13

    double whitespace before "is"
    not part of this changeset it seems?
  3. Sascha Egerer uploaded patch set 2 08/27/13, 13:02

  4. Mr. Jenkins commented on patch set 2 08/27/13, 13:02

  5. Sascha Egerer commented on patch set 1 08/27/13, 13:03

    Reply

    Done

    Reply

    It is. Just changed the suffix form "_test_SHA1HASH" to "_ftSHA1HASH"
  6. Christian Kuhn uploaded patch set 3 08/27/13, 13:06

  7. Mr. Jenkins commented on patch set 3 08/27/13, 13:06

  8. Christian Kuhn commented on patch set 3 V +2 CR +2 08/27/13, 13:09

    Works. Will merge, patch is not intrusive and pretty obvious.
  9. Christian Kuhn merged patch set 4 08/27/13, 13:09