23360[BUGFIX] Manipulation of file field migration config
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Tom Peters +1
- Markus Klein +1
Issues 1
Files 2
Review log 20
-
Mr. Jenkins commented on patch set 1 08/27/13, 12:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10253/ : SUCCESS -
Tom Peters commented on patch set 1 V +1 CR +1 11/20/13, 12:56
I tested the function 'registerAdditionalTypeForMigration' with two own CType extensions in Typo3 6.2 (Beta 1 and newest master). In my test the fields ‘image’ and ‘media’ are working again. (E.g. rendering an image on template level with a copy of tt_content.image.20 ) -
Stefan Neufeind commented on patch set 1 11/24/13, 20:01
Manipulation -
Alexander Stehlik uploaded patch set 2 11/25/13, 08:54
-
Alexander Stehlik commented on patch set 2 11/25/13, 08:54
Fixed typo in commit message. -
Mr. Jenkins commented on patch set 2 11/25/13, 09:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12312/ : SUCCESS -
Tom Peters voted on patch set 2 V +1 CR +1 12/05/13, 14:30
-
Markus Klein commented on patch set 2 CR -1 12/05/13, 14:37
Without knowing the details: Is this really BUGFIX or more a hidden FEATURE??Releases line missing -
Alexander Stehlik commented on patch set 2 12/05/13, 16:49
Good point, Markus. You could consider it as a feature. If we do so, Ernesto needs to decide if the feature freeze can be broken for this one because otherwise the whole concept would not be very useful. -
Markus Klein commented on patch set 2 02/26/14, 23:27
No matter what, it needs a documentation ticket and the according reference here in the cmtmsg. -
Markus Klein commented on patch set 2 02/26/14, 23:46
Reply
And documentation-line missingFrontendContentAdapterService.php:36Why array on the new line? Does it exceed the 120 chars ruler already?FrontendContentAdapterService.php:40I'd change the naming to $availableMigrationFieldsFrontendContentAdapterService.php:157space missingFrontendContentAdapterService.php:164typo in additionalFrontendContentAdapterService.php:183don't make $types NULL, but typehint on array and initialize with empty arrayFrontendContentAdapterService.php:189then the second check is useless. -
Alexander Stehlik commented on patch set 2 02/27/14, 08:56
Thank you! New version with unit tests will be uploaded in a second. All your inline comments should be fixed.FrontendContentAdapterService.php:157ReplyYou mean "The" should start with a capital letter?FrontendContentAdapterService.php:189ReplyRestructured it a bit, there was a bug in the check anyway. -
Alexander Stehlik uploaded patch set 3 02/27/14, 08:57
-
Mr. Jenkins commented on patch set 3 02/27/14, 09:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14372/ : SUCCESS -
Markus Klein commented on patch set 3 CR +1 02/27/14, 13:20
I'll change my vote for the disable patch, such we that we got both patches in. -
Markus Klein voted on patch set 3 V +1 03/18/14, 11:39
-
Tom Peters commented on patch set 3 V +1 03/19/14, 14:38
Tested in an own CType again and works fine. But i found another maybe more simple solution in Typoscript: tt_content.image.20.imgList > tt_content.image.20.imgList.cObject = FILES tt_content.image.20.imgList.cObject{ references{ table = tt_content uid.data = tt_content:uid fieldName = image } renderObj = TEXT renderObj{ stdWrap.data = file:current:uid_local stdWrap.wrap = ||,||,|*| } } -
Markus Klein commented on patch set 3 03/19/14, 17:20
@Tom: Yes that's how you should do it in 6.2+ This is for compatibility only. -
Stefan Neufeind voted on patch set 3 V +2 CR +2 03/21/14, 22:51
-
Stefan Neufeind merged patch set 4 03/21/14, 22:51