23369[TASK] Move default salt methods to factory function
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 5
- typo3/sysext/saltedpasswords/Classes/Salt/SaltFactory.php+32 −6
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+2 −1
- typo3/sysext/saltedpasswords/Classes/Utility/SaltedPasswordsUtility.php+1 −1
- typo3/sysext/saltedpasswords/Documentation/DevelopersGuide/Index.rst+1 −1
- typo3/sysext/saltedpasswords/ext_localconf.php+2 −6
Review log 15
-
Mr. Jenkins commented on patch set 1 08/27/13, 16:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10266/ : SUCCESS -
Nicole Hummel uploaded patch set 2 08/27/13, 16:13
-
Mr. Jenkins commented on patch set 2 08/27/13, 16:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10267/ : SUCCESS -
Nicole Hummel uploaded patch set 3 08/27/13, 16:21
-
Mr. Jenkins commented on patch set 3 08/27/13, 16:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10268/ : SUCCESS -
Christian Kuhn uploaded patch set 4 08/27/13, 17:18
-
Mr. Jenkins commented on patch set 4 08/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10276/ : SUCCESS -
Christian Kuhn uploaded patch set 5 08/27/13, 17:22
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/27/13, 17:22
-
Mr. Jenkins commented on patch set 5 08/27/13, 17:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10277/ : SUCCESS -
Christian Kuhn uploaded patch set 6 08/27/13, 17:26
-
Christian Kuhn voted on patch set 6 V +1 CR +1 08/27/13, 17:26
-
Mr. Jenkins commented on patch set 6 08/27/13, 17:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10278/ : SUCCESS -
Wouter Wolters commented on patch set 6 V +2 CR +2 08/27/13, 17:31
Tested the login and checked the configuration part in the EM. All works fine. -
Wouter Wolters merged patch set 7 08/27/13, 17:31