Review main Merged

23369[TASK] Move default salt methods to factory function

Nicole Hummel CR +2 V +2 Normal +38 −15 updated 08/27/13, 17:31

Commit message

To use saltedpasswords in the install tool it is necessary to move the
default salt methods registration from ext_localconf.php to the salt
factory. This patch adds an initialize function to set the default salt
methods.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 5

Review log 15

  1. Mr. Jenkins commented on patch set 1 08/27/13, 16:13

  2. Nicole Hummel uploaded patch set 2 08/27/13, 16:13

  3. Mr. Jenkins commented on patch set 2 08/27/13, 16:14

  4. Nicole Hummel uploaded patch set 3 08/27/13, 16:21

  5. Mr. Jenkins commented on patch set 3 08/27/13, 16:21

  6. Christian Kuhn uploaded patch set 4 08/27/13, 17:18

  7. Mr. Jenkins commented on patch set 4 08/27/13, 17:19

  8. Christian Kuhn uploaded patch set 5 08/27/13, 17:22

  9. Christian Kuhn voted on patch set 5 V +1 CR +1 08/27/13, 17:22

  10. Mr. Jenkins commented on patch set 5 08/27/13, 17:22

  11. Christian Kuhn uploaded patch set 6 08/27/13, 17:26

  12. Christian Kuhn voted on patch set 6 V +1 CR +1 08/27/13, 17:26

  13. Mr. Jenkins commented on patch set 6 08/27/13, 17:26

  14. Wouter Wolters commented on patch set 6 V +2 CR +2 08/27/13, 17:31

    Tested the login and checked the configuration part in the EM. All works fine.
  15. Wouter Wolters merged patch set 7 08/27/13, 17:31