Review main Merged

23400[TASK] Cleanup BackendUtitlity::displayWarningMessages

Kai Ole Hartwig CR +2 V +2 Normal +31 −131 updated 08/28/13, 18:03

Commit message

As the report tool checks system environment with the use of the hook
witin that function, we can deprecate the function in the BackendUtility
and move the hook to the appropriate extension "aboutmodules".

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 14

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 08/28/13, 12:35

  2. Kai Ole Hartwig uploaded patch set 2 08/28/13, 12:45

  3. Mr. Jenkins commented on patch set 2 08/28/13, 12:46

  4. Markus Klein commented on patch set 2 CR -1 08/28/13, 13:41

    Sorry I've to give -1, since this patch has too many flaws. See comments please.
    don't break apart words

    BackendUtility.php:3945

    @deprecated

    BackendUtility.php:3950

    Wrong API. ::logDeprecatedFunction()

    BackendUtility.php:3952

    Function still has to work. So this is not possible here. You have to invoke the new function here, otherwise deprecation does not make sense, as we'd break compatibilty
  5. Christian Kuhn commented on patch set 2 08/28/13, 14:41

    ModulesController.php:46

    please indent with tabs.

    BackendUtility.php:3952 Reply

    nah. In this case it is intended that the method does not return anything anymore.
  6. Markus Klein commented on patch set 2 08/28/13, 14:47

    BackendUtility.php:3952 Reply

    Ok then. Thx for clearification.
  7. Kai Ole Hartwig uploaded patch set 3 08/28/13, 15:20

  8. Mr. Jenkins commented on patch set 3 08/28/13, 15:21

  9. Markus Klein voted on patch set 3 CR +1 08/28/13, 15:33

  10. Christian Kuhn uploaded patch set 4 08/28/13, 15:47

  11. Mr. Jenkins commented on patch set 4 08/28/13, 15:48

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 08/28/13, 15:50

  13. Wouter Wolters voted on patch set 4 V +2 CR +2 08/28/13, 18:03

  14. Wouter Wolters merged patch set 5 08/28/13, 18:03