23400[TASK] Cleanup BackendUtitlity::displayWarningMessages
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 3
Review log 14
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 08/28/13, 12:35
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/10323/ : FAILURE -
Kai Ole Hartwig uploaded patch set 2 08/28/13, 12:45
-
Mr. Jenkins commented on patch set 2 08/28/13, 12:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10324/ : SUCCESS -
Markus Klein commented on patch set 2 CR -1 08/28/13, 13:41
Sorry I've to give -1, since this patch has too many flaws. See comments please.don't break apart wordsBackendUtility.php:3945@deprecatedBackendUtility.php:3950Wrong API. ::logDeprecatedFunction()BackendUtility.php:3952Function still has to work. So this is not possible here. You have to invoke the new function here, otherwise deprecation does not make sense, as we'd break compatibilty -
Christian Kuhn commented on patch set 2 08/28/13, 14:41
ModulesController.php:46please indent with tabs.BackendUtility.php:3952Replynah. In this case it is intended that the method does not return anything anymore. -
Markus Klein commented on patch set 2 08/28/13, 14:47
BackendUtility.php:3952ReplyOk then. Thx for clearification. -
Kai Ole Hartwig uploaded patch set 3 08/28/13, 15:20
-
Mr. Jenkins commented on patch set 3 08/28/13, 15:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10336/ : SUCCESS -
Markus Klein voted on patch set 3 CR +1 08/28/13, 15:33
-
Christian Kuhn uploaded patch set 4 08/28/13, 15:47
-
Mr. Jenkins commented on patch set 4 08/28/13, 15:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10337/ : SUCCESS -
Christian Kuhn voted on patch set 4 V +1 CR +1 08/28/13, 15:50
-
Wouter Wolters voted on patch set 4 V +2 CR +2 08/28/13, 18:03
-
Wouter Wolters merged patch set 5 08/28/13, 18:03