Review main Merged

23424[BUGFIX] Database integrity check fatal error

Stefan Fürst CR +2 V +2 Easy +1 −1 updated 08/29/13, 13:50

Commit message

If a file or directory below uploads/ is not readable by the
executing user, the integrity check system in db check module
menu may fatal. This is sanatized by the patch.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 08/28/13, 14:49

  2. Markus Klein commented on patch set 1 08/28/13, 14:58

    Please describe where and why the fatal error occurs.
    Please do not put change-id into a separate paragraph! Consider downloading the most current commit-msg hook from the wiki.
  3. Markus Klein commented on patch set 1 08/28/13, 15:00

    DatabaseIntegrityCheck.php:558

    prefix with @ please
  4. Stefan Fürst uploaded patch set 2 08/29/13, 13:04

  5. Mr. Jenkins commented on patch set 2 08/29/13, 13:05

  6. Markus Klein commented on patch set 2 08/29/13, 13:28

    Isn't 6.x affected as a whole?
  7. Christian Kuhn updated the commit message in patch set 2 08/29/13, 13:47

  8. Christian Kuhn commented on patch set 3 V +2 CR +2 08/29/13, 13:48

    Merged: Took me a while to reproduce, but was able to test patch successfully. The patch itself is pretty obvious and merged now.
  9. Christian Kuhn merged patch set 4 08/29/13, 13:48

  10. Christian Kuhn commented on patch set 4 08/29/13, 13:48

    Cherry Picked This patchset was cherry picked to change: Ide3401c014aa7bec33585083f81f30c00100da09
  11. Christian Kuhn commented on patch set 4 08/29/13, 13:48

    Cherry Picked This patchset was cherry picked to change: Ide3401c014aa7bec33585083f81f30c00100da09
  12. Mr. Jenkins commented on patch set 3 08/29/13, 13:50