Review main Abandoned

23436[BUGFIX] Replace [:alnum:] with 0-9A-Za-z in regex, escaping for . and -

Lucas Bremgartner CR 0 V 0 Normal +217 −1 updated 09/01/13, 20:42

Commit message

[:alnum:] breaks tests with utf-8 strings and leads
to utf-8 sequence EF BF BD (replacement character).
Unit tests are added for BasicFileUtility.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 12

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 08/28/13, 21:41

  2. Lucas Bremgartner uploaded patch set 2 08/29/13, 19:40

  3. Mr. Jenkins commented on patch set 2 CR -1 V -1 08/29/13, 19:42

  4. Sascha Egerer commented on patch set 2 CR -1 08/30/13, 13:39

    +--------------------------------------------------------+ | Please follow the conventions for Git commit messages. | | See http://wiki.typo3.org/CommitMessage_Format_(Git) | | Getting this error just at pushing to Gerrit, update your commit-msg hook by run the following command: | | curl -o .git/hooks/commit-msg http://wiki.typo3.org/wiki/images/5/5c/Commit-msg.txt && chmod +x .git/hooks/commit-msg | +--------------------------------------------------------+
  5. Philipp Gampe commented on patch set 2 08/31/13, 16:08

    You do not want this line ... the second line must always be empty

    BasicFileUtilityTest.php:35

    please configure your IDE to trim empty lines

    BasicFileUtilityTest.php:129

    missing closing parenthesis
  6. Philipp Gampe updated the commit message in patch set 2 08/31/13, 16:09

  7. Mr. Jenkins commented on patch set 3 CR -1 V -1 08/31/13, 16:10

  8. Philipp Gampe commented on patch set 3 CR -1 08/31/13, 16:10

    Please see my other comments ... that is also why Jenkins complains.
    Missing Resolves: #xxxxx Please open a new issue on forge for every patchset and give the issue number here.
  9. Philipp Gampe updated the commit message in patch set 3 08/31/13, 16:11

  10. Mr. Jenkins commented on patch set 4 08/31/13, 16:12

  11. Philipp Gampe commented on patch set 4 CR -1 08/31/13, 16:13

    I fixed your commit message, except for the missing issue number. Jenkins is happy now, but please push another patchset taking care of the comments in the last three patchsets.
  12. Lucas Bremgartner abandoned the change 09/01/13, 20:42

    Pushed this change to https://review.typo3.org/#/c/22725/ where it belongs (and where I wanted to push the change in the first place).