23437[TASK] Removed unnecessary test
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 8
-
Mr. Jenkins commented on patch set 1 08/28/13, 21:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10346/ : SUCCESS -
Christian Kuhn commented on patch set 1 08/29/13, 08:50
why is it unnecessary? -
Lucas Bremgartner commented on patch set 1 08/29/13, 11:33
because it is redundant to the test "ISO-8859-1 (code > 127)" (line 158). It wasn't my intention to commit the removed test in Commit https://review.typo3.org/#/c/23436/. The second commit is simple to correct my own mistake. -
Lucas Bremgartner uploaded patch set 2 08/29/13, 19:40
-
Mr. Jenkins commented on patch set 2 08/29/13, 19:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10401/ : SUCCESS -
Sascha Egerer commented on patch set 2 CR -1 08/30/13, 13:37
Why do you remove this test? You have added it by your own in Change-Id: I93fa0c692771a0656e95680d25e6317cd2659040 that is not merged yet... -
Philipp Gampe commented on patch set 2 CR -1 08/31/13, 16:22
Please only push one commit at a time to review.typo3.org. Otherwise you will create a dependency between both patches. Different commits will always show as own change requests on Gerrit. Thus to correct your commit, please amend your changes instead of committing them on top of the other commit. Please abandon this change request and modify your other change request instead. -
Lucas Bremgartner abandoned the change 09/01/13, 19:33
Following request of Philipp Gampe, two commit in one push.