23439[TASK] Consolidate regexp for utf8 and non-utf8 file systems
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Stefan Neufeind +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 4
Review log 49
Show 24 earlier messages
-
Lucas Bremgartner uploaded patch set 2 08/29/13, 19:40
-
Mr. Jenkins commented on patch set 2 08/29/13, 19:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10399/ : SUCCESS -
Lucas Bremgartner commented on patch set 2 09/01/13, 20:55
This change implements the consolidation of the regular expressions for utf-8 and non utf-8 filesystems suggested by Stefan Neufeind in https://review.typo3.org/#/c/22725/. It is up to you to decide, if the regular expressions should be consolidated or if the should left independent. -
Stefan Neufeind commented on patch set 2 CR +1 11/14/13, 18:00
According to http://en.wikipedia.org/wiki/UTF-8 all below and including 0x7F (127) is identical in ASCII and UTF8. For everything above the already accepted UTF8-range this patch then adds an include for non-UTF8-filesystems. -
Stefan Neufeind commented on patch set 2 11/14/13, 18:01
6.2, 6.1, 6.0, 4.5 And maybe not even 4.5 anymore since this is a "bigger" change? -
Markus Klein commented on patch set 2 CR -1 11/14/13, 22:07
Has a dependency on an abandoned patch -
Stefan Neufeind uploaded patch set 3 11/14/13, 23:48
-
Stefan Neufeind voted on patch set 3 CR +1 11/14/13, 23:48
-
Mr. Jenkins commented on patch set 3 11/15/13, 00:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12075/ : SUCCESS -
Markus Klein rebased onto patch set 3 01/16/14, 22:46
-
Markus Klein updated the commit message in patch set 4 01/16/14, 22:50
-
Mr. Jenkins commented on patch set 4 01/16/14, 22:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13064/ : SUCCESS -
Mr. Jenkins commented on patch set 5 01/16/14, 23:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13065/ : SUCCESS -
Stefan Neufeind voted on patch set 5 CR +1 01/16/14, 23:28
-
Stefan Neufeind commented on patch set 5 01/24/14, 00:02
Would be great if somebody could share his/her thoughts on this. -
Markus Klein commented on patch set 5 CR +1 01/24/14, 12:28
How to verify? -
Stefan Neufeind commented on patch set 5 01/24/14, 13:00
See forge-ticket. Currently characters like @ (commonly used for retina-imagefiles for example) are cleaned away from filenames if UTF8filesystem is false. If true, it would be allowed. Also please see the Wikipedia-link I gave in a previous comment here on gerrit (or another source) to verify the common characters between UTF8 and non-UTF8. -
Oliver Klee commented on patch set 5 01/24/14, 13:15
BasicFileUtility.php:500Maybe move it to a well-named class constant? Then the comment will not be necessary anymore. -
Stefan Neufeind commented on patch set 5 01/24/14, 14:03
BasicFileUtility.php:500ReplyIf you have a good name, go ahead and please adjust it/push again. -
Oliver Klee uploaded patch set 6 01/24/14, 18:38
-
Mr. Jenkins commented on patch set 6 01/24/14, 18:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13199/ : SUCCESS -
Stefan Neufeind commented on patch set 6 CR +1 01/24/14, 19:54
BasicFileUtility.php:46Do we have an official wording whether it's "file name" or maybe "filename"? If somebody pushes another version, I'd have that as one word. -
Oliver Klee commented on patch set 6 01/24/14, 20:03
According to leo, both versions are correct. I'm okay with both variants. -
Ernesto Baschny commented on patch set 6 01/28/14, 13:52
I would also like to see the real "change" being described in the commit message, which is that the "@" character is now allowed also on non-UTF8 file systems in the filename, which is what most people will be interested in when looking at this change. Haven't tested it thou. :)
-
Markus Klein uploaded patch set 7 02/24/14, 22:25
-
Markus Klein updated the commit message in patch set 7 02/24/14, 22:27
-
Markus Klein voted on patch set 8 CR +1 02/24/14, 22:27
-
Mr. Jenkins commented on patch set 7 02/24/14, 22:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14296/ : SUCCESS -
Markus Klein uploaded patch set 9 02/24/14, 22:47
-
Markus Klein commented on patch set 9 CR +1 02/24/14, 22:47
Added testcases now from https://review.typo3.org/22725 -
Mr. Jenkins commented on patch set 8 02/24/14, 22:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14297/ : SUCCESS -
Mr. Jenkins commented on patch set 9 02/24/14, 23:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14299/ : SUCCESS -
Stefan Neufeind commented on patch set 9 CR +1 02/24/14, 23:14
Comparing the charsets imho this looks okay. -
Benni Mack commented on patch set 9 CR -1 02/25/14, 21:49
please see, that in Resource/LocalDriver - there is the same function "sanitizeFileName". I would suggest replacing both. -
Markus Klein uploaded patch set 10 02/25/14, 22:31
-
Markus Klein uploaded patch set 11 02/25/14, 22:34
-
Markus Klein commented on patch set 11 V +1 CR +1 02/25/14, 22:35
Thanks for the hint Benni!! I moved the tests to the LocalDriver. They make much more sense there as BasicFileUtility is deprecated anyway. -
Mr. Jenkins commented on patch set 10 02/25/14, 22:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14308/ : SUCCESS -
Mr. Jenkins commented on patch set 11 02/25/14, 22:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14309/ : SUCCESS -
Wouter Wolters commented on patch set 11 V -1 02/25/14, 23:12
Fails on my system, too late to figure out why -
Stefan Neufeind commented on patch set 11 03/03/14, 14:08
any news? -
Markus Klein commented on patch set 11 CR -1 03/03/14, 20:01
LocalDriverTest.php:1386$GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem'] = 0; missing here -
Wouter Wolters commented on patch set 11 03/03/14, 20:55
The problem here is the use of an uppercase charset. This is passed all the way down to initCharset. Here it will try to open 'Resources/Private/Charsets/csconvtbl/' . $charset . '.tbl' All these files have lowercase filenames. This will lead to a not found conversion table. Can we just do a strtolower on the $charset variable to prevent this issue? -
Markus Klein uploaded patch set 12 03/03/14, 22:48
-
Markus Klein voted on patch set 12 V +1 CR +1 03/03/14, 22:48
-
Mr. Jenkins commented on patch set 12 03/03/14, 23:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14526/ : SUCCESS -
Stefan Neufeind voted on patch set 12 CR +1 03/04/14, 08:09
-
Wouter Wolters voted on patch set 12 V +2 CR +2 03/06/14, 22:29
-
Wouter Wolters merged patch set 13 03/06/14, 22:29