Review main Merged

23439[TASK] Consolidate regexp for utf8 and non-utf8 file systems

Lucas Bremgartner CR +2 V +2 Normal +222 −8 updated 03/06/14, 22:29

Commit message

This patch enables the @ character to be usable now
also for non-utf8 file systems.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Stefan Neufeind +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 4

Review log 49

Show 24 earlier messages
  1. Lucas Bremgartner uploaded patch set 2 08/29/13, 19:40

  2. Mr. Jenkins commented on patch set 2 08/29/13, 19:41

  3. Lucas Bremgartner commented on patch set 2 09/01/13, 20:55

    This change implements the consolidation of the regular expressions for utf-8 and non utf-8 filesystems suggested by Stefan Neufeind in https://review.typo3.org/#/c/22725/. It is up to you to decide, if the regular expressions should be consolidated or if the should left independent.
  4. Stefan Neufeind commented on patch set 2 CR +1 11/14/13, 18:00

    According to http://en.wikipedia.org/wiki/UTF-8 all below and including 0x7F (127) is identical in ASCII and UTF8. For everything above the already accepted UTF8-range this patch then adds an include for non-UTF8-filesystems.
  5. Stefan Neufeind commented on patch set 2 11/14/13, 18:01

    6.2, 6.1, 6.0, 4.5 And maybe not even 4.5 anymore since this is a "bigger" change?
  6. Markus Klein commented on patch set 2 CR -1 11/14/13, 22:07

    Has a dependency on an abandoned patch
  7. Stefan Neufeind uploaded patch set 3 11/14/13, 23:48

  8. Stefan Neufeind voted on patch set 3 CR +1 11/14/13, 23:48

  9. Mr. Jenkins commented on patch set 3 11/15/13, 00:00

  10. Markus Klein rebased onto patch set 3 01/16/14, 22:46

  11. Markus Klein updated the commit message in patch set 4 01/16/14, 22:50

  12. Mr. Jenkins commented on patch set 4 01/16/14, 22:59

  13. Mr. Jenkins commented on patch set 5 01/16/14, 23:12

  14. Stefan Neufeind voted on patch set 5 CR +1 01/16/14, 23:28

  15. Stefan Neufeind commented on patch set 5 01/24/14, 00:02

    Would be great if somebody could share his/her thoughts on this.
  16. Markus Klein commented on patch set 5 CR +1 01/24/14, 12:28

    How to verify?
  17. Stefan Neufeind commented on patch set 5 01/24/14, 13:00

    See forge-ticket. Currently characters like @ (commonly used for retina-imagefiles for example) are cleaned away from filenames if UTF8filesystem is false. If true, it would be allowed. Also please see the Wikipedia-link I gave in a previous comment here on gerrit (or another source) to verify the common characters between UTF8 and non-UTF8.
  18. Oliver Klee commented on patch set 5 01/24/14, 13:15

    BasicFileUtility.php:500

    Maybe move it to a well-named class constant? Then the comment will not be necessary anymore.
  19. Stefan Neufeind commented on patch set 5 01/24/14, 14:03

    BasicFileUtility.php:500 Reply

    If you have a good name, go ahead and please adjust it/push again.
  20. Oliver Klee uploaded patch set 6 01/24/14, 18:38

  21. Mr. Jenkins commented on patch set 6 01/24/14, 18:50

  22. Stefan Neufeind commented on patch set 6 CR +1 01/24/14, 19:54

    BasicFileUtility.php:46

    Do we have an official wording whether it's "file name" or maybe "filename"? If somebody pushes another version, I'd have that as one word.
  23. Oliver Klee commented on patch set 6 01/24/14, 20:03

    According to leo, both versions are correct. I'm okay with both variants.
  24. Ernesto Baschny commented on patch set 6 01/28/14, 13:52

    I would also like to see the real "change" being described in the commit message, which is that the "@" character is now allowed also on non-UTF8 file systems in the filename, which is what most people will be interested in when looking at this change. Haven't tested it thou. :)
  1. Markus Klein uploaded patch set 7 02/24/14, 22:25

  2. Markus Klein updated the commit message in patch set 7 02/24/14, 22:27

  3. Markus Klein voted on patch set 8 CR +1 02/24/14, 22:27

  4. Mr. Jenkins commented on patch set 7 02/24/14, 22:40

  5. Markus Klein uploaded patch set 9 02/24/14, 22:47

  6. Markus Klein commented on patch set 9 CR +1 02/24/14, 22:47

    Added testcases now from https://review.typo3.org/22725
  7. Mr. Jenkins commented on patch set 8 02/24/14, 22:52

  8. Mr. Jenkins commented on patch set 9 02/24/14, 23:07

  9. Stefan Neufeind commented on patch set 9 CR +1 02/24/14, 23:14

    Comparing the charsets imho this looks okay.
  10. Benni Mack commented on patch set 9 CR -1 02/25/14, 21:49

    please see, that in Resource/LocalDriver - there is the same function "sanitizeFileName". I would suggest replacing both.
  11. Markus Klein uploaded patch set 10 02/25/14, 22:31

  12. Markus Klein uploaded patch set 11 02/25/14, 22:34

  13. Markus Klein commented on patch set 11 V +1 CR +1 02/25/14, 22:35

    Thanks for the hint Benni!! I moved the tests to the LocalDriver. They make much more sense there as BasicFileUtility is deprecated anyway.
  14. Mr. Jenkins commented on patch set 10 02/25/14, 22:44

  15. Mr. Jenkins commented on patch set 11 02/25/14, 22:53

  16. Wouter Wolters commented on patch set 11 V -1 02/25/14, 23:12

    Fails on my system, too late to figure out why
  17. Stefan Neufeind commented on patch set 11 03/03/14, 14:08

    any news?
  18. Markus Klein commented on patch set 11 CR -1 03/03/14, 20:01

    LocalDriverTest.php:1386

    $GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem'] = 0; missing here
  19. Wouter Wolters commented on patch set 11 03/03/14, 20:55

    The problem here is the use of an uppercase charset. This is passed all the way down to initCharset. Here it will try to open 'Resources/Private/Charsets/csconvtbl/' . $charset . '.tbl' All these files have lowercase filenames. This will lead to a not found conversion table. Can we just do a strtolower on the $charset variable to prevent this issue?
  20. Markus Klein uploaded patch set 12 03/03/14, 22:48

  21. Markus Klein voted on patch set 12 V +1 CR +1 03/03/14, 22:48

  22. Mr. Jenkins commented on patch set 12 03/03/14, 23:02

  23. Stefan Neufeind voted on patch set 12 CR +1 03/04/14, 08:09

  24. Wouter Wolters voted on patch set 12 V +2 CR +2 03/06/14, 22:29

  25. Wouter Wolters merged patch set 13 03/06/14, 22:29