Review main Merged

23445[TASK] Skip tests that rely on internet connection

Anja Leichsenring CR +2 V +2 Easy +0 −0 updated 08/29/13, 16:24

Commit message

Some tests in GeneralUtilityTest rely on a working internet
connection and fail if offline. Skip those tests if no needed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 08/29/13, 10:12

  2. Anja Leichsenring uploaded patch set 2 08/29/13, 10:17

  3. Mr. Jenkins commented on patch set 2 CR -1 V -1 08/29/13, 10:18

  4. Christian Kuhn uploaded patch set 3 08/29/13, 10:36

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 08/29/13, 10:36

  6. Mr. Jenkins commented on patch set 3 CR -1 V -1 08/29/13, 10:37

  7. Christian Kuhn uploaded patch set 4 08/29/13, 10:42

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 08/29/13, 10:42

  9. Mr. Jenkins commented on patch set 4 08/29/13, 10:42

  10. Susi Moog voted on patch set 4 V +1 CR +1 08/29/13, 16:24

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 08/29/13, 16:24

  12. Christian Kuhn merged patch set 5 08/29/13, 16:24