23464[TASK] FAL-Drivers: Make getFileInfo more versatile and performant
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
Issues 1
Files 3
Review log 26
Show 1 earlier messages
-
Steffen Ritter commented on patch set 1 CR -2 08/29/13, 13:12
to much files in it
-
Mr. Jenkins commented on patch set 1 08/29/13, 13:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10377/ : SUCCESS -
Steffen Ritter uploaded patch set 2 08/29/13, 13:16
-
Mr. Jenkins commented on patch set 2 08/29/13, 13:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10378/ : SUCCESS -
Frans Saris commented on patch set 2 CR -1 08/29/13, 13:23
LocalDriver.php:237extractFileInformation() has not third parameter -
Steffen Ritter uploaded patch set 3 08/29/13, 14:00
-
Mr. Jenkins commented on patch set 3 08/29/13, 14:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10383/ : SUCCESS -
Steffen Ritter uploaded patch set 4 08/29/13, 14:10
-
Steffen Ritter commented on patch set 4 08/29/13, 14:11
Sorry, It took me 5 patch sets to finally push the right subset of files without any merge errors. -
Mr. Jenkins commented on patch set 4 08/29/13, 14:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10384/ : SUCCESS -
Frans Saris commented on patch set 4 CR -1 08/29/13, 15:37
general idea looks good.AbstractDriver.php:387Maybe add some extra description to this parameter about what these properties are for and rename te property to something like $propertiesToExtractLocalDriver.php:220phpdocs misses new property and rename te property to something like $propertiesToExtractLocalDriverTest.php:291why did you remove the tests without a replacement? -
Steffen Ritter commented on patch set 4 08/29/13, 15:40
LocalDriverTest.php:291Replybecause the function which is tested has been removed -
Steffen Ritter uploaded patch set 5 08/30/13, 08:28
-
Mr. Jenkins commented on patch set 5 08/30/13, 08:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10409/ : SUCCESS -
Steffen Ritter commented on patch set 5 08/30/13, 08:29
fixed the doc-comment thingies in patchset 5 -
Sascha Egerer uploaded patch set 6 08/30/13, 14:22
-
Mr. Jenkins commented on patch set 6 08/30/13, 14:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10420/ : SUCCESS -
Sascha Egerer commented on patch set 4 08/30/13, 14:23
LocalDriverTest.php:291ReplyWhat about unit tests for getSpecificFileInformation? -
Frans Saris commented on patch set 6 V +1 CR +1 10/10/13, 15:26
Looks good to me. Only question remains is the one from Sascha "What about unit tests for getSpecificFileInformation?" Should we add a test or tests? -
Steffen Ritter commented on patch set 6 10/10/13, 15:36
we cannot mock the mtime functions, unit test there does not make sense IMHO. If we would do a Unit test, it should test if the correct fnction is called. But that is not possible - so it does not make sense. -
Oliver Hader commented on patch set 6 V +1 CR +1 10/11/13, 13:11
AbstractDriver.php:382This breaks compatibility in existing implementations (PHP 5.3) - so, if we put that only to 6.2, it's fine... -
Oliver Hader updated the commit message in patch set 6 10/11/13, 13:13
-
Oliver Hader voted on patch set 7 V +2 10/11/13, 13:13
-
Oliver Hader voted on patch set 7 CR +2 10/11/13, 13:13
-
Oliver Hader merged patch set 8 10/11/13, 13:13
-
Mr. Jenkins commented on patch set 7 10/11/13, 14:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11264/ : SUCCESS