Review main Merged

23478[BUGFIX] Sprite manager cache improvement

Christian Kuhn CR +2 V +2 Easy +5 −5 updated 08/29/13, 19:58

Commit message

The sprite manager cache entry is created and then required
directly again. This may lead to runtime issues if the file
is required already before it is fully written.
The patch optimizes that by setting the runtime information
directly from the given data.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Sascha Egerer +1
  • Verified V +2
    • Wouter Wolters +2
    • Sascha Egerer +1

Issues 1

Files 1

Review log 8

  1. Christian Kuhn uploaded patch set 2 08/29/13, 19:44

  2. Mr. Jenkins commented on patch set 1 08/29/13, 19:44

  3. Mr. Jenkins commented on patch set 2 08/29/13, 19:45

  4. Sascha Egerer voted on patch set 2 V +1 CR +1 08/29/13, 19:53

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 08/29/13, 19:58

  6. Wouter Wolters merged patch set 3 08/29/13, 19:58

  7. Wouter Wolters commented on patch set 3 08/29/13, 19:58

    Cherry Picked This patchset was cherry picked to change: I3f6250d8513dad32e266538a075abc8e3daeb68c
  8. Wouter Wolters commented on patch set 3 08/29/13, 19:58

    Cherry Picked This patchset was cherry picked to change: I3f6250d8513dad32e266538a075abc8e3daeb68c