Review main Merged

23485[TASK] Categorize sys_file table by default

Steffen Ritter CR +2 V +2 Easy +28 −1 updated 10/11/13, 10:51

Commit message

To be able to migrate from DAM, sys_files need to be
categorizable. The core is able to do so, but would
need to be configured manually. To ease migration
this is now activated by default.

If an upgrading installation already modified the
list of categorized tables in its localconf, the
step installer takes care of adding sys_file to
that list silently.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frans Saris +1
  • Verified V +2
    • Christian Kuhn +2
    • Frans Saris +1

Issues 1

Files 2

Review log 31

Show 6 earlier messages
  1. Mr. Jenkins commented on patch set 1 08/30/13, 09:24

  2. Mattias Nilsson commented on patch set 1 CR -1 08/30/13, 09:43

    no -> now
  3. Christian Kuhn commented on patch set 1 08/30/13, 10:27

    categrizable :)
  4. Christian Kuhn commented on patch set 1 08/30/13, 10:28

    looks good.
  5. Kai Ole Hartwig uploaded patch set 2 08/30/13, 12:40

  6. Mattias Nilsson voted on patch set 2 CR +1 08/30/13, 12:41

  1. Mr. Jenkins commented on patch set 2 08/30/13, 12:41

  2. Kai Ole Hartwig voted on patch set 2 V +1 CR +1 08/30/13, 12:48

  3. Wouter Wolters commented on patch set 2 CR -1 08/31/13, 12:18

    StepController.php:340

    strict check for in_array
  4. Steffen Ritter commented on patch set 2 10/09/13, 10:11

    StepController.php:340 Reply

    why?
  5. Sascha Egerer commented on patch set 2 10/10/13, 15:45

    StepController.php:340 Reply

    Yes, why?
  6. Frans Saris commented on patch set 2 10/10/13, 15:46

    StepController.php:340 Reply

    in_array only returns true or false so strict doesn't make sense there. And also the strict param isn't needed because you search for a string in a array with strings.
  7. Frans Saris uploaded patch set 3 10/10/13, 15:57

  8. Frans Saris commented on patch set 3 10/10/13, 15:58

    Rebased and changed comments a little.
  9. Mr. Jenkins commented on patch set 3 10/10/13, 16:10

  10. Frans Saris uploaded patch set 4 10/10/13, 16:35

  11. Mr. Jenkins commented on patch set 4 10/10/13, 16:48

  12. Frans Saris commented on patch set 4 V +1 CR +1 10/11/13, 08:20

    Did some little changes. getLocalConfigurationValueByPath() expects a path with / as delimiter and not a dot. And getLocalConfigurationValueByPath() throws an exception when you try to fetch a non existing path.
  13. Christian Kuhn commented on patch set 4 CR -1 10/11/13, 08:44

    StepController.php:62

    method needs to be moved to silent upgrade class.
  14. Frans Saris uploaded patch set 5 10/11/13, 09:30

  15. Frans Saris commented on patch set 4 10/11/13, 09:31

    Can I still vote for this patch or did I change to much?

    StepController.php:62 Reply

    Done
  16. Christian Kuhn commented on patch set 5 10/11/13, 09:54

    yeah, please vote on it, frans.
  17. Frans Saris voted on patch set 5 V +1 CR +1 10/11/13, 09:56

  18. Christian Kuhn commented on patch set 5 CR -1 10/11/13, 10:01

    SilentConfigurationUpgradeService.php:422

    \RuntimeException

    SilentConfigurationUpgradeService.php:426

    this may give warnings if $actual = NULL, move it within the if?
  19. Mr. Jenkins commented on patch set 5 10/11/13, 10:01

  20. Christian Kuhn uploaded patch set 6 10/11/13, 10:04

  21. Christian Kuhn voted on patch set 6 V +1 CR +1 10/11/13, 10:11

  22. Frans Saris voted on patch set 6 V +1 CR +1 10/11/13, 10:13

  23. Christian Kuhn voted on patch set 6 V +2 CR +2 10/11/13, 10:15

  24. Christian Kuhn merged patch set 7 10/11/13, 10:15

  25. Mr. Jenkins commented on patch set 6 10/11/13, 10:51