23485[TASK] Categorize sys_file table by default
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frans Saris +1
-
Verified V +2
- Christian Kuhn +2
- Frans Saris +1
Issues 1
Files 2
Review log 31
Show 6 earlier messages
-
Mr. Jenkins commented on patch set 1 08/30/13, 09:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10412/ : SUCCESS -
Mattias Nilsson commented on patch set 1 CR -1 08/30/13, 09:43
no -> now -
Christian Kuhn commented on patch set 1 08/30/13, 10:27
categrizable :) -
Christian Kuhn commented on patch set 1 08/30/13, 10:28
looks good. -
Kai Ole Hartwig uploaded patch set 2 08/30/13, 12:40
-
Mattias Nilsson voted on patch set 2 CR +1 08/30/13, 12:41
-
Mr. Jenkins commented on patch set 2 08/30/13, 12:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10418/ : SUCCESS -
Kai Ole Hartwig voted on patch set 2 V +1 CR +1 08/30/13, 12:48
-
Wouter Wolters commented on patch set 2 CR -1 08/31/13, 12:18
StepController.php:340strict check for in_array -
Steffen Ritter commented on patch set 2 10/09/13, 10:11
StepController.php:340Replywhy? -
Sascha Egerer commented on patch set 2 10/10/13, 15:45
StepController.php:340ReplyYes, why? -
Frans Saris commented on patch set 2 10/10/13, 15:46
StepController.php:340Replyin_array only returns true or false so strict doesn't make sense there. And also the strict param isn't needed because you search for a string in a array with strings. -
Frans Saris uploaded patch set 3 10/10/13, 15:57
-
Frans Saris commented on patch set 3 10/10/13, 15:58
Rebased and changed comments a little. -
Mr. Jenkins commented on patch set 3 10/10/13, 16:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11216/ : SUCCESS -
Frans Saris uploaded patch set 4 10/10/13, 16:35
-
Mr. Jenkins commented on patch set 4 10/10/13, 16:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11218/ : SUCCESS -
Frans Saris commented on patch set 4 V +1 CR +1 10/11/13, 08:20
Did some little changes. getLocalConfigurationValueByPath() expects a path with / as delimiter and not a dot. And getLocalConfigurationValueByPath() throws an exception when you try to fetch a non existing path. -
Christian Kuhn commented on patch set 4 CR -1 10/11/13, 08:44
StepController.php:62method needs to be moved to silent upgrade class. -
Frans Saris uploaded patch set 5 10/11/13, 09:30
-
Frans Saris commented on patch set 4 10/11/13, 09:31
Can I still vote for this patch or did I change to much?StepController.php:62ReplyDone -
Christian Kuhn commented on patch set 5 10/11/13, 09:54
yeah, please vote on it, frans. -
Frans Saris voted on patch set 5 V +1 CR +1 10/11/13, 09:56
-
Christian Kuhn commented on patch set 5 CR -1 10/11/13, 10:01
SilentConfigurationUpgradeService.php:422\RuntimeExceptionSilentConfigurationUpgradeService.php:426this may give warnings if $actual = NULL, move it within the if? -
Mr. Jenkins commented on patch set 5 10/11/13, 10:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11241/ : SUCCESS -
Christian Kuhn uploaded patch set 6 10/11/13, 10:04
-
Christian Kuhn voted on patch set 6 V +1 CR +1 10/11/13, 10:11
-
Frans Saris voted on patch set 6 V +1 CR +1 10/11/13, 10:13
-
Christian Kuhn voted on patch set 6 V +2 CR +2 10/11/13, 10:15
-
Christian Kuhn merged patch set 7 10/11/13, 10:15
-
Mr. Jenkins commented on patch set 6 10/11/13, 10:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11245/ : SUCCESS