Review main Abandoned

23486[BUGFIX] Remove hardcoded alternative label from pagebrowser list view

Michael Schams CR 0 V 0 Easy +1 −1 updated 01/29/15, 19:47

Commit message

Pagebrowser list view shows label "Page" as the fall-back value if the
value is empty at run-time. This results in undesirable output at the
frontend under certain circumstances. This patch removes the hardcoded
value from the core.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 08/30/13, 11:14

  2. Philipp Gampe commented on patch set 1 CR -1 08/31/13, 16:27

    This patch breaks the behavior of the function. Instead of removing the string, please localize it. Then you can simply override the localization with an empty string.
  3. Mathias Schreiber wrote 12/18/14, 08:16

    Topic set to FE AbstractPlugin
  4. Ryan Klarhölter commented on patch set 1 CR -1 12/22/14, 17:13

  5. Benni Mack abandoned the change 01/29/15, 19:47

    As mentioned in forge, this issue is not related to the core but a wanted behaviour.