Review main Merged

23536[BUGFIX] TS: Allow "0" as strPad.padWith

Lars Malach CR +2 V +2 Easy +10 −1 updated 11/24/13, 20:44

Commit message

Replaces the test with empty() by isset() and
strlen() > 0. So other strings which are
handled by PHP as empty can be used for padding.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 2

Review log 18

  1. Mr. Jenkins commented on patch set 1 09/02/13, 13:28

  2. Alexander Opitz commented on patch set 1 09/02/13, 13:40

    ContentObjectRenderer.php:2362

    Did you mean: isset($conf['strPad.']['padWith']) && strlen($conf['strPad.']['padWith']) > 0
  3. Lars Malach uploaded patch set 2 09/02/13, 13:57

  4. Mr. Jenkins commented on patch set 2 09/02/13, 13:57

  5. Lars Malach commented on patch set 2 09/02/13, 13:59

    Sorry, I added another commit into "Depends On".. (I downloaded the patch not with a cherry-pick). Do I have to create a new review?
  6. Alexander Opitz updated the commit message in patch set 2 09/02/13, 18:28

  7. Alexander Opitz voted on patch set 3 CR +1 09/02/13, 18:28

  8. Mr. Jenkins commented on patch set 3 CR -1 V -1 09/02/13, 18:29

  9. Lars Malach uploaded patch set 4 09/02/13, 20:38

  10. Mr. Jenkins commented on patch set 4 09/02/13, 20:39

  11. Lars Malach voted on patch set 4 V +1 CR +1 09/02/13, 20:40

  12. Alexander Opitz commented on patch set 4 CR +1 09/04/13, 15:46

    @Lars You shouldn't Review your own source code inside Gerrit. Reviews are done by someone else.
  13. Stefan Neufeind updated the commit message in patch set 4 11/24/13, 20:24

  14. Stefan Neufeind uploaded patch set 6 11/24/13, 20:30

  15. Stefan Neufeind commented on patch set 6 V +2 CR +2 11/24/13, 20:31

    Code unchanged, so review from Alexander still applies. Just added a testcase for this change. Easy one, so I think merging this is safe enough.
  16. Stefan Neufeind merged patch set 7 11/24/13, 20:31

  17. Mr. Jenkins commented on patch set 5 11/24/13, 20:37

  18. Mr. Jenkins commented on patch set 6 11/24/13, 20:44