23536[BUGFIX] TS: Allow "0" as strPad.padWith
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 2
Review log 18
-
Mr. Jenkins commented on patch set 1 09/02/13, 13:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10478/ : SUCCESS -
Alexander Opitz commented on patch set 1 09/02/13, 13:40
ContentObjectRenderer.php:2362Did you mean: isset($conf['strPad.']['padWith']) && strlen($conf['strPad.']['padWith']) > 0 -
Lars Malach uploaded patch set 2 09/02/13, 13:57
-
Mr. Jenkins commented on patch set 2 09/02/13, 13:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10480/ : SUCCESS -
Lars Malach commented on patch set 2 09/02/13, 13:59
Sorry, I added another commit into "Depends On".. (I downloaded the patch not with a cherry-pick). Do I have to create a new review? -
Alexander Opitz updated the commit message in patch set 2 09/02/13, 18:28
-
Alexander Opitz voted on patch set 3 CR +1 09/02/13, 18:28
-
Mr. Jenkins commented on patch set 3 CR -1 V -1 09/02/13, 18:29
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/10483/ : FAILURE -
Lars Malach uploaded patch set 4 09/02/13, 20:38
-
Mr. Jenkins commented on patch set 4 09/02/13, 20:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10487/ : SUCCESS -
Lars Malach voted on patch set 4 V +1 CR +1 09/02/13, 20:40
-
Alexander Opitz commented on patch set 4 CR +1 09/04/13, 15:46
@Lars You shouldn't Review your own source code inside Gerrit. Reviews are done by someone else. -
Stefan Neufeind updated the commit message in patch set 4 11/24/13, 20:24
-
Stefan Neufeind uploaded patch set 6 11/24/13, 20:30
-
Stefan Neufeind commented on patch set 6 V +2 CR +2 11/24/13, 20:31
Code unchanged, so review from Alexander still applies. Just added a testcase for this change. Easy one, so I think merging this is safe enough. -
Stefan Neufeind merged patch set 7 11/24/13, 20:31
-
Mr. Jenkins commented on patch set 5 11/24/13, 20:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12307/ : SUCCESS -
Mr. Jenkins commented on patch set 6 11/24/13, 20:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12308/ : SUCCESS