23546[BUGFIX] Replace old images by sprite
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Piotr Molewski +1
- Tymoteusz Motylewski +1
-
Verified V +2
- Wouter Wolters +2
- Tymoteusz Motylewski +1
Issues 1
Files 6
- typo3/sysext/backend/Classes/History/RecordHistory.php2+2 −2
- typo3/sysext/core/ext_tables.php+2 −0
- typo3/sysext/t3skin/images/icons/actions/markstate.pngnewbinary
- typo3/sysext/t3skin/images/icons/actions/unmarkstate.pngnewbinary
- typo3/sysext/t3skin/images/sprites/t3skin.pngbinary
- typo3/sysext/t3skin/stylesheets/sprites/t3skin.css+1004 −992
Review log 15
-
Mr. Jenkins commented on patch set 1 09/02/13, 19:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10485/ : SUCCESS -
Francois Suter commented on patch set 1 09/02/13, 20:22
Did you by any chance forget to add the individual icons themselves? They need to be included for the next time when the sprite is rebuilt. -
Krzysztof Adamczyk uploaded patch set 2 09/03/13, 06:42
-
Mr. Jenkins commented on patch set 2 09/03/13, 06:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10489/ : SUCCESS -
Wouter Wolters commented on patch set 2 09/03/13, 06:54
RecordHistory.php:457second parameter is a boolean and needs to be TRUE. Also add a space after a comma.RecordHistory.php:459same here -
Krzysztof Adamczyk uploaded patch set 3 09/03/13, 09:25
-
Mr. Jenkins commented on patch set 3 09/03/13, 09:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10490/ : SUCCESS -
Tymoteusz Motylewski commented on patch set 3 09/03/13, 09:44
should be "Replace" -
Wouter Wolters updated the commit message in patch set 3 09/03/13, 10:09
-
Mr. Jenkins commented on patch set 4 09/03/13, 10:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10491/ : SUCCESS -
Tymoteusz Motylewski commented on patch set 4 V +1 CR +1 09/05/13, 15:47
Testing instructions: go to the backedn to the "History/undo" view and without this patch icons for marking/unmarking change are not using sprites. Additionally "marked checkbox" icon is missing. This patch fixes both issues. -
Piotr Molewski voted on patch set 4 V +1 CR +1 09/06/13, 11:45
-
Piotr Molewski voted on patch set 4 CR +1 09/06/13, 12:15
-
Wouter Wolters voted on patch set 4 V +2 CR +2 09/06/13, 16:05
-
Wouter Wolters merged patch set 5 09/06/13, 16:05