Review main Merged

23546[BUGFIX] Replace old images by sprite

Krzysztof Adamczyk CR +2 V +2 Expert +1008 −994 updated 09/06/13, 16:05

Commit message

Adding new images to sprite

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Piotr Molewski +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1

Issues 1

Files 6

Review log 15

  1. Mr. Jenkins commented on patch set 1 09/02/13, 19:46

  2. Francois Suter commented on patch set 1 09/02/13, 20:22

    Did you by any chance forget to add the individual icons themselves? They need to be included for the next time when the sprite is rebuilt.
  3. Krzysztof Adamczyk uploaded patch set 2 09/03/13, 06:42

  4. Mr. Jenkins commented on patch set 2 09/03/13, 06:42

  5. Wouter Wolters commented on patch set 2 09/03/13, 06:54

    RecordHistory.php:457

    second parameter is a boolean and needs to be TRUE. Also add a space after a comma.

    RecordHistory.php:459

    same here
  6. Krzysztof Adamczyk uploaded patch set 3 09/03/13, 09:25

  7. Mr. Jenkins commented on patch set 3 09/03/13, 09:25

  8. Tymoteusz Motylewski commented on patch set 3 09/03/13, 09:44

    should be "Replace"
  9. Wouter Wolters updated the commit message in patch set 3 09/03/13, 10:09

  10. Mr. Jenkins commented on patch set 4 09/03/13, 10:10

  11. Tymoteusz Motylewski commented on patch set 4 V +1 CR +1 09/05/13, 15:47

    Testing instructions: go to the backedn to the "History/undo" view and without this patch icons for marking/unmarking change are not using sprites. Additionally "marked checkbox" icon is missing. This patch fixes both issues.
  12. Piotr Molewski voted on patch set 4 V +1 CR +1 09/06/13, 11:45

  13. Piotr Molewski voted on patch set 4 CR +1 09/06/13, 12:15

  14. Wouter Wolters voted on patch set 4 V +2 CR +2 09/06/13, 16:05

  15. Wouter Wolters merged patch set 5 09/06/13, 16:05