Review TYPO3_6-1 Merged

23573[FEATURE] Add getValidators to AbstractCompositeValidator

Stefan Froemken CR +2 V +2 Easy +12 −3 updated 10/14/13, 22:56

Commit message

removeValidator is unusable as long as there is no method
to get contained validators

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 2

Review log 8

  1. Georg Ringer voted on patch set 1 V +1 CR +1 09/04/13, 07:18

  2. Xavier Perseguers voted on patch set 1 CR +1 09/25/13, 06:34

  3. Stefan Neufeind commented on patch set 1 CR +1 10/14/13, 22:39

    and 6.2 For this special case I agree we could/should have it down to 6.0
  4. Stefan Neufeind updated the commit message in patch set 1 10/14/13, 22:52

  5. Stefan Neufeind commented on patch set 2 V +2 CR +2 10/14/13, 22:54

    Votes still count. Just added 6.2 to the releases-line. Flow has getValidators as well. https://git.typo3.org/Packages/TYPO3.Flow.git/blob/master:/Classes/TYPO3/Flow/Validation/Validator/AbstractCompositeValidator.php And it really makes so much more sense to have this function. Imho down to 6.0 ...
  6. Stefan Neufeind merged patch set 3 10/14/13, 22:54

  7. Stefan Neufeind commented on patch set 3 10/14/13, 22:56

    hmm, we already have it in 6.2. So this is just down to 6.1/6.0 only ...
  8. Stefan Neufeind commented on patch set 3 10/14/13, 22:56

    Cherry Picked This patchset was cherry picked to change: If8705e8b5c7c2dfa84a732b97813d6097930f209