Review TYPO3_6-1 Merged

23604[SECURITY] Deny arbitrary code execution possibility for editors

Oliver Hader CR +2 V +2 Easy +15 −1 updated 09/04/13, 11:23

Commit message

Because the filename is sanitized in the driver
after the check for denied file extensions is
performed, it was still possible to rename files
with denied file extensions.

We now perform the file extension check
on the final filename which is going to be used
by the driver.

This change makes the sanitizing method public
and introduces a basic implementation in
AbstractDriver to not break existing driver
implementations.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Files 3

Review log 2

  1. Oliver Hader commented on patch set 1 CR +2 V +2 09/04/13, 11:23

    Auto-approved
  2. Oliver Hader merged patch set 2 09/04/13, 11:23