Review main Merged

23696[BUGFIX] Do not add trailing slashes to files

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 09/09/13, 16:25

Commit message

In the security fix #50883 a canonicalize method
for folders has been used where items could
either be files or folders.

This added a trailing slash to files which triggered
a basedir PHP warning if basedir is configured
in PHP.

Use the canonicalize method for file paths instead
to fix this issue.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Simon Schick +1
  • Verified V +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Simon Schick +1

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 09/09/13, 15:14

  2. Simon Schick voted on patch set 1 V +1 CR +1 09/09/13, 15:45

  3. Stefan Neufeind commented on patch set 1 V +1 CR +1 09/09/13, 15:59

    ALso folder-names path this check. But those look look fine as well (for is_dir()-checking).
  4. Helmut Hummel voted on patch set 1 V +2 CR +2 09/09/13, 16:25

  5. Helmut Hummel merged patch set 2 09/09/13, 16:25

  6. Helmut Hummel commented on patch set 2 09/09/13, 16:25

    Cherry Picked This patchset was cherry picked to change: I9ef4b6a90ca257ad0104115bd7d48c4de68f135f
  7. Helmut Hummel commented on patch set 2 09/09/13, 16:25

    Cherry Picked This patchset was cherry picked to change: I9ef4b6a90ca257ad0104115bd7d48c4de68f135f