Review TYPO3_6-1 Merged

23698[BUGFIX] Do not add trailing slashes to files

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 09/09/13, 16:26

Commit message

In the security fix #50883 a canonicalize method
for folders has been used where items could
either be files or folders.

This added a trailing slash to files which triggered
a basedir PHP warning if basedir is configured
in PHP.

Use the canonicalize method for file paths instead
to fix this issue.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 2

  1. Helmut Hummel voted on patch set 1 V +2 CR +2 09/09/13, 16:26

  2. Helmut Hummel merged patch set 2 09/09/13, 16:26