23740[BUGFIX] URL-encoded title in link wizard
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Oliver Klee +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Files 2
Review log 51
Show 26 earlier messages
-
Mr. Jenkins commented on patch set 1 09/11/13, 10:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10611/ : SUCCESS -
Markus Klein updated the commit message in patch set 1 09/11/13, 10:53
-
Helmut Hummel commented on patch set 1 09/11/13, 10:54
ElementBrowser.php:372I think the rawurlencode can also be removed -
Mr. Jenkins commented on patch set 2 09/11/13, 10:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10612/ : SUCCESS -
Helmut Hummel uploaded patch set 3 09/11/13, 10:57
-
Mr. Jenkins commented on patch set 3 09/11/13, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10613/ : SUCCESS -
Helmut Hummel uploaded patch set 4 09/11/13, 10:59
-
Mr. Jenkins commented on patch set 4 09/11/13, 11:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10614/ : SUCCESS -
Georg Ringer voted on patch set 4 V +1 CR +1 09/11/13, 11:57
-
Stefan Neufeind commented on patch set 4 CR +1 09/11/13, 12:14
Makes sense by reading. I stumbled across some parts, but it turned out that they actually also made sense. Didn't spot errors so far. -
Markus Klein voted on patch set 4 CR +1 09/11/13, 13:21
-
Markus Klein commented on patch set 4 V -1 09/11/13, 13:42
The following does not work: (empty link) -> use wizard -> set no CSS, title _foo "bar" foo_ -> _top Saving the content element and reopening the wizard suddenly has the values distributed over all fields. Escaping of " fails. -
Markus Klein voted on patch set 4 CR 0 09/11/13, 13:44
-
Markus Klein commented on patch set 4 12/18/13, 13:25
Ping. This is still a regression to a security release!! -
Markus Klein commented on patch set 4 02/06/14, 18:29
I just ran into this issue myself. Also the additional parameters field is affected! -
Stefan Neufeind commented on patch set 4 02/06/14, 18:45
@Markus: are you maybe able to see where this patch goes wrong, if you can reproduce it on your environment? Would be great. -
Markus Klein commented on patch set 4 02/06/14, 19:26
I'll do this tomorrow -
Markus Klein uploaded patch set 5 02/07/14, 10:49
-
Markus Klein commented on patch set 5 02/07/14, 10:49
Rebased. Working on this now. -
Mr. Jenkins commented on patch set 5 02/07/14, 11:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13785/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13784/ : SUCCESS -
Markus Klein updated the commit message in patch set 5 02/07/14, 11:30
-
Markus Klein commented on patch set 6 V +1 CR +1 02/07/14, 11:31
Works now. The handling of quotes in the title will be part of a separate patch. -
Mr. Jenkins commented on patch set 6 02/07/14, 11:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13787/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13786/ : SUCCESS -
Stefan Neufeind voted on patch set 6 CR +1 02/07/14, 12:01
-
Wouter Wolters voted on patch set 6 CR +1 02/18/14, 22:12
-
Tymoteusz Motylewski commented on patch set 6 02/20/14, 15:44
BrowseLinks.php:413this is a breaking change isn't it? there is a missing $conf= array(); assignment before the "_params"
-
Markus Klein commented on patch set 6 02/20/14, 15:56
BrowseLinks.php:413ReplyIt does not matter, what we specify here, it is never used afterwards. -
Tymoteusz Motylewski commented on patch set 6 02/20/14, 16:14
BrowseLinks.php:413Replyall other hooks, also in ElementBrowser from which this class inherits has sth like: $conf = array(); $_params = array( 'conf' => &$conf, ... so if it's not a difference for you, I would like to have consistent code here also. -
Markus Klein commented on patch set 6 02/20/14, 22:45
BrowseLinks.php:413ReplyOk. fine of course -
Markus Klein uploaded patch set 7 02/20/14, 22:48
-
Markus Klein uploaded patch set 8 02/20/14, 22:50
-
Markus Klein voted on patch set 8 V +1 CR +1 02/20/14, 22:50
-
Mr. Jenkins commented on patch set 7 02/20/14, 23:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14209/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14208/ : SUCCESS -
Mr. Jenkins commented on patch set 8 02/20/14, 23:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14210/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14209/ : SUCCESS -
Oliver Klee commented on patch set 8 02/21/14, 19:54
Tiny nitpick if there will be a next version: Url encoded -> URL-encoded -
Stefan Neufeind voted on patch set 8 CR +1 02/21/14, 23:49
-
Markus Klein updated the commit message in patch set 8 02/22/14, 10:07
-
Markus Klein commented on patch set 9 V +1 CR +1 02/22/14, 10:08
just fixed the commit message. -
Mr. Jenkins commented on patch set 9 02/22/14, 10:20
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14242/ : SUCCESS -
Stefan Neufeind commented on patch set 9 02/22/14, 10:27
Works fine for me in the LinkWizard. So I'm +1 for that part. !!! Inserting double-quotes into the "title"-attribute of a link by default generates a link in frontend where the quotes are *not* escaped. But I expect that's a different bug? -
Oliver Klee voted on patch set 9 CR +1 02/22/14, 10:35
-
Stefan Neufeind commented on patch set 9 02/24/14, 23:03
Could somebody please say whether the non-escaping should be handled in a separate issue? Sounds like we should get this thing resolved somehow ... -
Markus Klein commented on patch set 9 02/24/14, 23:23
Yes, escaping in a separate issue! No other way. -
Markus Klein commented on patch set 9 02/25/14, 17:45
Please please please. One more test to get this nasty regression fixed!! -
Wouter Wolters voted on patch set 9 V +2 CR +2 02/25/14, 19:50
-
Wouter Wolters merged patch set 10 02/25/14, 19:50
-
Markus Klein commented on patch set 10 02/25/14, 20:13
ElementBrowser.php:983one closing ) too much. Fixed in backports. Follow up coming along -
Markus Klein commented on patch set 10 02/25/14, 20:38
ElementBrowser.php:983ReplyFixed in http://forge.typo3.org/issues/56289 -
Tobias Wollender commented on patch set 10 02/26/14, 12:28
With this Patch applied on 6.2 master, the linkbrowser for input fields (e. g. header_link) doesn't work correctly anymore. The tab "Page" gets displayed, but a click on any other tab results in a white page in the linkbrowser. The linkbrowser in the RTE works fine. -
Markus Klein commented on patch set 10 02/26/14, 22:18
Tobias, see my comments in the forge ticket please. there were two follow ups you'll need. Please use git pull to get on current master. -
Markus Klein commented on patch set 10 09/29/14, 11:21
ElementBrowser.php:1535Regression here: Missing ) https://forge.typo3.org/issues/61943