Review main Merged

23740[BUGFIX] URL-encoded title in link wizard

Helmut Hummel CR +2 V +2 Normal +46 −43 updated 09/29/14, 11:21

Commit message

The security fix introduced a bug that the title is encoded
every time the link wizard is opened, leading to multiple
encoded strings.

Solution is to not encode it centrally but encode it just
before using it in the JavaScript context.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Oliver Klee +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Files 2

Review log 51

Show 26 earlier messages
  1. Mr. Jenkins commented on patch set 1 09/11/13, 10:51

  2. Markus Klein updated the commit message in patch set 1 09/11/13, 10:53

  3. Helmut Hummel commented on patch set 1 09/11/13, 10:54

    ElementBrowser.php:372

    I think the rawurlencode can also be removed
  4. Mr. Jenkins commented on patch set 2 09/11/13, 10:54

  5. Helmut Hummel uploaded patch set 3 09/11/13, 10:57

  6. Mr. Jenkins commented on patch set 3 09/11/13, 10:58

  7. Helmut Hummel uploaded patch set 4 09/11/13, 10:59

  8. Mr. Jenkins commented on patch set 4 09/11/13, 11:00

  9. Georg Ringer voted on patch set 4 V +1 CR +1 09/11/13, 11:57

  10. Stefan Neufeind commented on patch set 4 CR +1 09/11/13, 12:14

    Makes sense by reading. I stumbled across some parts, but it turned out that they actually also made sense. Didn't spot errors so far.
  11. Markus Klein voted on patch set 4 CR +1 09/11/13, 13:21

  12. Markus Klein commented on patch set 4 V -1 09/11/13, 13:42

    The following does not work: (empty link) -> use wizard -> set no CSS, title _foo "bar" foo_ -> _top Saving the content element and reopening the wizard suddenly has the values distributed over all fields. Escaping of " fails.
  13. Markus Klein voted on patch set 4 CR 0 09/11/13, 13:44

  14. Markus Klein commented on patch set 4 12/18/13, 13:25

    Ping. This is still a regression to a security release!!
  15. Markus Klein commented on patch set 4 02/06/14, 18:29

    I just ran into this issue myself. Also the additional parameters field is affected!
  16. Stefan Neufeind commented on patch set 4 02/06/14, 18:45

    @Markus: are you maybe able to see where this patch goes wrong, if you can reproduce it on your environment? Would be great.
  17. Markus Klein commented on patch set 4 02/06/14, 19:26

    I'll do this tomorrow
  18. Markus Klein uploaded patch set 5 02/07/14, 10:49

  19. Markus Klein commented on patch set 5 02/07/14, 10:49

    Rebased. Working on this now.
  20. Mr. Jenkins commented on patch set 5 02/07/14, 11:19

  21. Markus Klein updated the commit message in patch set 5 02/07/14, 11:30

  22. Markus Klein commented on patch set 6 V +1 CR +1 02/07/14, 11:31

    Works now. The handling of quotes in the title will be part of a separate patch.
  23. Mr. Jenkins commented on patch set 6 02/07/14, 11:48

  24. Stefan Neufeind voted on patch set 6 CR +1 02/07/14, 12:01

  25. Wouter Wolters voted on patch set 6 CR +1 02/18/14, 22:12

  26. Tymoteusz Motylewski commented on patch set 6 02/20/14, 15:44

    BrowseLinks.php:413

    this is a breaking change isn't it? there is a missing $conf= array(); assignment before the "_params"
  1. Markus Klein commented on patch set 6 02/20/14, 15:56

    BrowseLinks.php:413 Reply

    It does not matter, what we specify here, it is never used afterwards.
  2. Tymoteusz Motylewski commented on patch set 6 02/20/14, 16:14

    BrowseLinks.php:413 Reply

    all other hooks, also in ElementBrowser from which this class inherits has sth like: $conf = array(); $_params = array( 'conf' => &$conf, ... so if it's not a difference for you, I would like to have consistent code here also.
  3. Markus Klein commented on patch set 6 02/20/14, 22:45

    BrowseLinks.php:413 Reply

    Ok. fine of course
  4. Markus Klein uploaded patch set 7 02/20/14, 22:48

  5. Markus Klein uploaded patch set 8 02/20/14, 22:50

  6. Markus Klein voted on patch set 8 V +1 CR +1 02/20/14, 22:50

  7. Mr. Jenkins commented on patch set 7 02/20/14, 23:02

  8. Mr. Jenkins commented on patch set 8 02/20/14, 23:16

  9. Oliver Klee commented on patch set 8 02/21/14, 19:54

    Tiny nitpick if there will be a next version: Url encoded -> URL-encoded
  10. Stefan Neufeind voted on patch set 8 CR +1 02/21/14, 23:49

  11. Markus Klein updated the commit message in patch set 8 02/22/14, 10:07

  12. Markus Klein commented on patch set 9 V +1 CR +1 02/22/14, 10:08

    just fixed the commit message.
  13. Mr. Jenkins commented on patch set 9 02/22/14, 10:20

  14. Stefan Neufeind commented on patch set 9 02/22/14, 10:27

    Works fine for me in the LinkWizard. So I'm +1 for that part. !!! Inserting double-quotes into the "title"-attribute of a link by default generates a link in frontend where the quotes are *not* escaped. But I expect that's a different bug?
  15. Oliver Klee voted on patch set 9 CR +1 02/22/14, 10:35

  16. Stefan Neufeind commented on patch set 9 02/24/14, 23:03

    Could somebody please say whether the non-escaping should be handled in a separate issue? Sounds like we should get this thing resolved somehow ...
  17. Markus Klein commented on patch set 9 02/24/14, 23:23

    Yes, escaping in a separate issue! No other way.
  18. Markus Klein commented on patch set 9 02/25/14, 17:45

    Please please please. One more test to get this nasty regression fixed!!
  19. Wouter Wolters voted on patch set 9 V +2 CR +2 02/25/14, 19:50

  20. Wouter Wolters merged patch set 10 02/25/14, 19:50

  21. Markus Klein commented on patch set 10 02/25/14, 20:13

    ElementBrowser.php:983

    one closing ) too much. Fixed in backports. Follow up coming along
  22. Markus Klein commented on patch set 10 02/25/14, 20:38

    ElementBrowser.php:983 Reply

  23. Tobias Wollender commented on patch set 10 02/26/14, 12:28

    With this Patch applied on 6.2 master, the linkbrowser for input fields (e. g. header_link) doesn't work correctly anymore. The tab "Page" gets displayed, but a click on any other tab results in a white page in the linkbrowser. The linkbrowser in the RTE works fine.
  24. Markus Klein commented on patch set 10 02/26/14, 22:18

    Tobias, see my comments in the forge ticket please. there were two follow ups you'll need. Please use git pull to get on current master.
  25. Markus Klein commented on patch set 10 09/29/14, 11:21

    ElementBrowser.php:1535

    Regression here: Missing ) https://forge.typo3.org/issues/61943