Review main Merged

23743[BUGFIX] No RTE Transformation for subtype_value_field-fields of plugins

Tim Lochmüller CR +2 V +2 Easy +11 −0 updated 12/07/14, 20:47

Commit message

The RTE transformation depends on the result of BackendUtility
getTCAtypes. If the RTE field is in the subtypes_addlist of a plugin
the transformation is not performed. The patch adds the related
subtype fields to the return value.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
  • Verified V +2
    • Helmut Hummel +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 17

  1. Mr. Jenkins commented on patch set 1 09/11/13, 13:02

  2. Tim Lochmüller uploaded patch set 2 09/11/13, 13:16

  3. Mr. Jenkins commented on patch set 2 09/11/13, 13:17

  4. Tim Spiekerkötter voted on patch set 2 V +1 CR +1 09/11/13, 13:18

  5. Mathias Schreiber commented on patch set 2 CR +1 V +1 12/07/14, 15:24

    works. Ran into this one earlier
  6. Helmut Hummel commented on patch set 2 CR -2 12/07/14, 15:27

    reviewing now
  7. Stefan Neufeind commented on patch set 2 CR -1 12/07/14, 15:29

    needs to be adapted
  8. Stefan Neufeind commented on patch set 2 12/07/14, 15:30

    lowercase "plugins" imho
    adds
  9. Stefan Neufeind commented on patch set 2 12/07/14, 15:31

    BackendUtility.php:722

    is
  10. Helmut Hummel uploaded patch set 3 12/07/14, 16:47

  11. Helmut Hummel commented on patch set 2 12/07/14, 16:49

    Reply

    Done

    Reply

    Done

    Reply

    Done
    @Stefan: if you find such minor typos in the commit message,next time please just fix them quickly using the Gerrit interface. Thanks!

    BackendUtility.php:722 Reply

    Done
  12. Helmut Hummel voted on patch set 3 CR +1 V +2 12/07/14, 16:49

  13. Mathias Schreiber voted on patch set 3 CR +1 V +1 12/07/14, 16:54

  14. Stefan Neufeind commented on patch set 3 12/07/14, 16:54

    @Helmut: I was quite sure you'd upload a new changeset soon anyway :-) But yes, usually I adjust commit-msg or so myself.
  15. Helmut Hummel voted on patch set 3 CR +2 12/07/14, 20:46

  16. Helmut Hummel merged patch set 3 12/07/14, 20:46

  17. Helmut Hummel commented on patch set 4 12/07/14, 20:47

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit f95698213fac580de67e5963af730c4d065c4abc