23794[FEATURE] Show string value for PHP error codes in install tool
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Christian Kuhn +1
Issues 1
Files 6
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Tool/AllConfiguration.php+20 −0
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php1new+80 −0
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/AllConfiguration/SubSection.html+7 −0
- typo3/sysext/install/Resources/Public/Stylesheets/Action/Common/Install.css+5 −0
- typo3/sysext/install/Tests/Unit/ViewHelpers/Format/PhpErrorCodeViewHelperTest.phpnew+83 −0
Review log 24
-
Mr. Jenkins commented on patch set 1 09/12/13, 17:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10687/ : SUCCESS -
Wouter Wolters uploaded patch set 2 09/12/13, 17:32
-
Mr. Jenkins commented on patch set 2 09/12/13, 17:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10688/ : SUCCESS -
Wouter Wolters uploaded patch set 3 09/12/13, 17:33
-
Wouter Wolters uploaded patch set 4 09/12/13, 17:34
-
Mr. Jenkins commented on patch set 3 09/12/13, 17:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10689/ : SUCCESS -
Wouter Wolters uploaded patch set 5 09/12/13, 17:35
-
Mr. Jenkins commented on patch set 4 09/12/13, 17:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10690/ : SUCCESS -
Mr. Jenkins commented on patch set 5 09/12/13, 17:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10691/ : SUCCESS -
Christian Kuhn commented on patch set 5 09/12/13, 18:36
duplicating the title is commit description is no benefit. -
Christian Kuhn uploaded patch set 6 09/12/13, 20:10
-
Mr. Jenkins commented on patch set 6 09/12/13, 20:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10696/ : SUCCESS -
Christian Kuhn commented on patch set 6 CR -1 09/12/13, 20:13
I like this approach in general and the controller code is ok. But i have the feeling that my own current settings are not extracted correctly again. I think it would be a very good idea to add unit tests to the view helper to see if it works as expected.PhpErrorCodeViewHelper.php:72"current value" should not be added by the view helper, but should be in the template. -
Christian Kuhn commented on patch set 6 09/12/13, 20:16
[SYS][exceptionalErrors] = 20480 with this setting, the view helper return nothing. is this correct? -
Ernesto Baschny uploaded patch set 7 09/14/13, 00:47
-
Mr. Jenkins commented on patch set 7 09/14/13, 00:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10725/ : SUCCESS -
Ernesto Baschny commented on patch set 7 V +1 CR +1 09/14/13, 00:49
Nice idea. Added some unit tests to the viewhelper and fixes the issues from the comments from Christian. -
Wouter Wolters commented on patch set 7 09/14/13, 10:31
Thanks Ernesto:-) One small note filename of the test is not in line with the rest, will fix this now. -
Wouter Wolters uploaded patch set 8 09/14/13, 10:32
-
Wouter Wolters commented on patch set 8 V +1 09/14/13, 10:33
My vote is only for the Unit-test and that all my numbers are also working now. -
Mr. Jenkins commented on patch set 8 09/14/13, 10:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10728/ : SUCCESS -
Christian Kuhn voted on patch set 8 V +1 CR +1 09/15/13, 12:30
-
Anja Leichsenring voted on patch set 8 V +2 CR +2 09/15/13, 13:12
-
Anja Leichsenring merged patch set 9 09/15/13, 13:12