Review main Merged

23794[FEATURE] Show string value for PHP error codes in install tool

Wouter Wolters CR +2 V +2 Normal +197 −2 updated 09/15/13, 13:12

Commit message

"All configuration" in install tool shows the integer representation
of the bit mask of the PHP error codes in settings like
['SYS']['errorHandlerErrors']. This change adds a view helper to
show the current setting in an E_* constants representation.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Christian Kuhn +1

Issues 1

Files 6

Review log 24

  1. Mr. Jenkins commented on patch set 1 09/12/13, 17:32

  2. Wouter Wolters uploaded patch set 2 09/12/13, 17:32

  3. Mr. Jenkins commented on patch set 2 09/12/13, 17:32

  4. Wouter Wolters uploaded patch set 3 09/12/13, 17:33

  5. Wouter Wolters uploaded patch set 4 09/12/13, 17:34

  6. Mr. Jenkins commented on patch set 3 09/12/13, 17:34

  7. Wouter Wolters uploaded patch set 5 09/12/13, 17:35

  8. Mr. Jenkins commented on patch set 4 09/12/13, 17:35

  9. Mr. Jenkins commented on patch set 5 09/12/13, 17:35

  10. Christian Kuhn commented on patch set 5 09/12/13, 18:36

    duplicating the title is commit description is no benefit.
  11. Christian Kuhn uploaded patch set 6 09/12/13, 20:10

  12. Mr. Jenkins commented on patch set 6 09/12/13, 20:11

  13. Christian Kuhn commented on patch set 6 CR -1 09/12/13, 20:13

    I like this approach in general and the controller code is ok. But i have the feeling that my own current settings are not extracted correctly again. I think it would be a very good idea to add unit tests to the view helper to see if it works as expected.

    PhpErrorCodeViewHelper.php:72

    "current value" should not be added by the view helper, but should be in the template.
  14. Christian Kuhn commented on patch set 6 09/12/13, 20:16

    [SYS][exceptionalErrors] = 20480 with this setting, the view helper return nothing. is this correct?
  15. Ernesto Baschny uploaded patch set 7 09/14/13, 00:47

  16. Mr. Jenkins commented on patch set 7 09/14/13, 00:48

  17. Ernesto Baschny commented on patch set 7 V +1 CR +1 09/14/13, 00:49

    Nice idea. Added some unit tests to the viewhelper and fixes the issues from the comments from Christian.
  18. Wouter Wolters commented on patch set 7 09/14/13, 10:31

    Thanks Ernesto:-) One small note filename of the test is not in line with the rest, will fix this now.
  19. Wouter Wolters uploaded patch set 8 09/14/13, 10:32

  20. Wouter Wolters commented on patch set 8 V +1 09/14/13, 10:33

    My vote is only for the Unit-test and that all my numbers are also working now.
  21. Mr. Jenkins commented on patch set 8 09/14/13, 10:33

  22. Christian Kuhn voted on patch set 8 V +1 CR +1 09/15/13, 12:30

  23. Anja Leichsenring voted on patch set 8 V +2 CR +2 09/15/13, 13:12

  24. Anja Leichsenring merged patch set 9 09/15/13, 13:12