Review main Merged

23840[BUGFIX] Install tool: Use sRGB colorspace in presets

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 09/15/13, 19:38

Commit message

Image Magick versions 6.7 and above need sRGB as colorspace,
otherwise images are too dark. This also works for older versions
like 6.6. Use sRGB as default is image configuration presets.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Steffen Müller +1
  • Verified V +2
    • Wouter Wolters +2
    • Steffen Müller +1

Issues 1

Files 1

Review log 18

  1. Mr. Jenkins commented on patch set 1 09/15/13, 13:53

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/15/13, 15:32

  3. Markus Klein commented on patch set 1 09/15/13, 16:06

  4. Markus Klein updated the commit message in patch set 1 09/15/13, 16:07

  5. Mr. Jenkins commented on patch set 2 09/15/13, 16:07

  6. Ernesto Baschny updated the commit message in patch set 2 09/15/13, 18:00

  7. Mr. Jenkins commented on patch set 3 09/15/13, 18:01

  8. Steffen Müller commented on patch set 3 V -1 CR -1 09/15/13, 18:44

    Works fine with Imagemagick 6.7.7 on Debian Wheezy Fails with Graphicsmagick 1.3.16 on Debian Wheezy Is this related to Graphicsmagick at all?
  9. Christian Kuhn commented on patch set 3 09/15/13, 19:07

    ah, yes. i'll test gm again, too.
  10. Christian Kuhn uploaded patch set 4 09/15/13, 19:17

  11. Christian Kuhn commented on patch set 4 09/15/13, 19:17

    gm should be good again (no change).
  12. Mr. Jenkins commented on patch set 4 09/15/13, 19:18

  13. Steffen Müller voted on patch set 4 V +1 CR +1 09/15/13, 19:21

  14. Wouter Wolters updated the commit message in patch set 4 09/15/13, 19:36

  15. Mr. Jenkins commented on patch set 5 09/15/13, 19:37

  16. Steffen Müller voted on patch set 5 V +1 CR +1 09/15/13, 19:38

  17. Wouter Wolters voted on patch set 5 V +2 CR +2 09/15/13, 19:38

  18. Wouter Wolters merged patch set 6 09/15/13, 19:38