Review main Merged

23857[BUGFIX] EmConfUtility accesses non-arrays

Markus Klein CR +2 V +2 Easy +38 −10 updated 09/26/13, 22:28

Commit message

Properly check for array-type before accessing
or counting the variable.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
    • Jigal van Hemert +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1
    • Jigal van Hemert +1

Issues 1

Files 2

Review log 17

  1. Mr. Jenkins commented on patch set 1 09/16/13, 19:21

  2. Wouter Wolters voted on patch set 1 CR +1 09/16/13, 19:21

  3. Kay Strobach voted on patch set 1 V +1 CR +1 09/17/13, 18:41

  4. Jigal van Hemert commented on patch set 1 09/18/13, 10:53

    EmConfUtility.php:139

    This check is not needed now that we are sure that $dependency[$type] is an array.
  5. Markus Klein commented on patch set 1 09/18/13, 11:00

    EmConfUtility.php:139 Reply

    Still the key might not be set
  6. Markus Klein uploaded patch set 2 09/18/13, 11:16

  7. Mr. Jenkins commented on patch set 2 09/18/13, 11:17

  8. Jigal van Hemert voted on patch set 2 V +1 CR +1 09/18/13, 11:31

  9. Anja Leichsenring uploaded patch set 3 09/18/13, 21:01

  10. Mr. Jenkins commented on patch set 3 09/18/13, 21:01

  11. Anja Leichsenring uploaded patch set 4 09/18/13, 21:07

  12. Anja Leichsenring commented on patch set 4 V +1 CR +1 09/18/13, 21:08

    added a unittest that raises the warning
  13. Mr. Jenkins commented on patch set 4 09/18/13, 21:08

  14. Jigal van Hemert voted on patch set 4 V +1 CR +1 09/19/13, 05:06

  15. Markus Klein commented on patch set 4 V +2 CR +2 09/26/13, 22:27

    Has enough votes. Merging.
  16. Markus Klein merged patch set 5 09/26/13, 22:27

  17. Markus Klein commented on patch set 5 09/26/13, 22:28

    Cherry Picked This patchset was cherry picked to change: Id161fddadbbcadd462de36e8227278107f2e7a3a