23865[TASK] Change injectMethods to annotations
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Neufeind +1
-
Verified V +2
- Markus Klein +2
- Stefan Neufeind +1
Issues 1
Files 40
- typo3/sysext/fluid/Classes/Compatibility/TemplateParserBuilder.php1+3 −2
- typo3/sysext/fluid/Classes/Core/Parser/Interceptor/Escape.php+1 −10
- typo3/sysext/fluid/Classes/Core/Parser/ParsingState.php+1 −11
- typo3/sysext/fluid/Classes/Core/Parser/TemplateParser.php+1 −10
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php2+3 −20
- typo3/sysext/fluid/Classes/Core/ViewHelper/AbstractTagBasedViewHelper.php+1 −10
- typo3/sysext/fluid/Classes/Core/ViewHelper/AbstractViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestHandler.php+5 −23
- typo3/sysext/fluid/Classes/Service/AbstractGenerator.php+2 −17
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+2 −20
- typo3/sysext/fluid/Classes/View/TemplateView.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Widget/PaginateViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormViewHelper.php+1 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/AutocompleteViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/PaginateViewHelper.php+1 −8
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+5 −41
- typo3/sysext/fluid/Tests/Unit/Core/Parser/Interceptor/EscapeTest.php+1 −1
Show 20 more files
- typo3/sysext/fluid/Tests/Unit/Core/Parser/SyntaxTree/ViewHelperNodeTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/Core/Parser/TemplateParserTest.php+13 −13
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/AbstractTagBasedViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/AbstractViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/View/StandaloneViewTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/ButtonViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/CheckboxViewHelperTest.php+8 −8
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/FormFieldViewHelperBaseTestcase.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/PasswordViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/RadioViewHelperTest.php+6 −6
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+5 −5
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SubmitViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextareaViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/TextfieldViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/UploadViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ViewHelperBaseTestcase.php+3 −3
Review log 21
-
Mr. Jenkins commented on patch set 1 09/17/13, 09:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10781/ : SUCCESS -
Xavier Perseguers commented on patch set 1 CR +1 09/25/13, 06:33
Unit tests are still green after patching. Will let it run for a while to check functionality. -
Xavier Perseguers commented on patch set 1 V -1 09/25/13, 06:47
When loading EM, it crashes with: Fatal error: Call to undefined method TYPO3\CMS\Fluid\Core\Rendering\RenderingContext::injectTemplateVariableContainer() in /path/to/typo3/sysext/fluid/Classes/View/AbstractTemplateView.php on line 272 -
Stefan Froemken uploaded patch set 2 09/26/13, 05:57
-
Stefan Froemken commented on patch set 2 09/26/13, 05:59
Thank you Xavier. I have reworked the patch and Installtool, Extensionmanager, phpUnit and many other modules more works again. -
Mr. Jenkins commented on patch set 2 09/26/13, 06:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10943/ : SUCCESS -
Christian Kuhn commented on patch set 2 V +1 CR +1 09/26/13, 19:13
This seems to work fine, unit tests are running and I didn't experience issues in the backend ... -
Wouter Wolters commented on patch set 2 V -1 CR -1 09/26/13, 21:50
PHP Fatal error: Call to a member function setView() on a non-object in /var/www/websites/master/htdocs/typo3/sysext/fluid/Classes/View/AbstractTemplateView.php on line 93 -
Christian Kuhn commented on patch set 2 V -1 09/26/13, 21:56
fails running tests. -
Marc Bastian Heinrichs wrote 10/21/13, 18:19
Topic set to "fluid". -
Oliver Hader uploaded patch set 3 11/11/13, 14:18
-
Oliver Hader commented on patch set 3 11/11/13, 14:19
Just resolved Git conflict... no further changes or review done... -
Mr. Jenkins commented on patch set 3 11/11/13, 14:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11961/ : SUCCESS -
Stefan Neufeind voted on patch set 3 CR +1 11/12/13, 11:56
-
Stefan Froemken commented on patch set 3 V +1 CR +1 11/14/13, 20:04
Funny. After solving the merge problem (thank you Olli) this patch seems to work very good. I don't have any problems on PHP 5.3 and PHP 5.4 and all UnitTest are running without any problems. As long as AjaxWidget of Fluid currently does not work I think this patch should made it into 6.2. -
Stefan Neufeind commented on patch set 3 V -1 11/14/13, 20:18
Stefan meant: The testsuite Core\Widget\AbstractWidgetControllerTest fails in viewConfigurationCanBeOverriddenThroughFrameworkConfiguration. That's because the inject in RenderingContext for $viewHelperVariableContainer does not work for some reason. Call to a member function setView() on a non-object in .../typo3/sysext/fluid/Classes/View/AbstractTemplateView.php on line 93 -
Stefan Neufeind commented on patch set 3 V +1 11/14/13, 20:32
It seems showstopper for me was some caching. Cleared all caches manually now just to be sure and it works now. I guess some cf_extbase_object or so might have been my problem. All (view) things I tested in the frontend also seemed to still work for me. -
Markus Klein commented on patch set 3 11/18/13, 23:09
TemplateParserBuilder.php:32return it directlyRenderingContext.php:61Why is this one preserved? -
Stefan Froemken commented on patch set 3 11/19/13, 08:24
See commentRenderingContext.php:61ReplyIt was called from some other classes directly. -
Markus Klein commented on patch set 3 V +2 CR +2 11/19/13, 09:48
Clicked through the BE and fluid tests are running fine. -
Markus Klein merged patch set 4 11/19/13, 09:48