Review main Merged

23865[TASK] Change injectMethods to annotations

Stefan Froemken CR +2 V +2 Hard +104 −302 updated 11/19/13, 09:48

Commit message

Change injectMethods as already done in extbase
to inject annotations

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1

Issues 1

Files 40

Show 20 more files

Review log 21

  1. Mr. Jenkins commented on patch set 1 09/17/13, 09:02

  2. Xavier Perseguers commented on patch set 1 CR +1 09/25/13, 06:33

    Unit tests are still green after patching. Will let it run for a while to check functionality.
  3. Xavier Perseguers commented on patch set 1 V -1 09/25/13, 06:47

    When loading EM, it crashes with: Fatal error: Call to undefined method TYPO3\CMS\Fluid\Core\Rendering\RenderingContext::injectTemplateVariableContainer() in /path/to/typo3/sysext/fluid/Classes/View/AbstractTemplateView.php on line 272
  4. Stefan Froemken uploaded patch set 2 09/26/13, 05:57

  5. Stefan Froemken commented on patch set 2 09/26/13, 05:59

    Thank you Xavier. I have reworked the patch and Installtool, Extensionmanager, phpUnit and many other modules more works again.
  6. Mr. Jenkins commented on patch set 2 09/26/13, 06:07

  7. Christian Kuhn commented on patch set 2 V +1 CR +1 09/26/13, 19:13

    This seems to work fine, unit tests are running and I didn't experience issues in the backend ...
  8. Wouter Wolters commented on patch set 2 V -1 CR -1 09/26/13, 21:50

    PHP Fatal error: Call to a member function setView() on a non-object in /var/www/websites/master/htdocs/typo3/sysext/fluid/Classes/View/AbstractTemplateView.php on line 93
  9. Christian Kuhn commented on patch set 2 V -1 09/26/13, 21:56

    fails running tests.
  10. Marc Bastian Heinrichs wrote 10/21/13, 18:19

    Topic set to "fluid".
  11. Oliver Hader uploaded patch set 3 11/11/13, 14:18

  12. Oliver Hader commented on patch set 3 11/11/13, 14:19

    Just resolved Git conflict... no further changes or review done...
  13. Mr. Jenkins commented on patch set 3 11/11/13, 14:31

  14. Stefan Neufeind voted on patch set 3 CR +1 11/12/13, 11:56

  15. Stefan Froemken commented on patch set 3 V +1 CR +1 11/14/13, 20:04

    Funny. After solving the merge problem (thank you Olli) this patch seems to work very good. I don't have any problems on PHP 5.3 and PHP 5.4 and all UnitTest are running without any problems. As long as AjaxWidget of Fluid currently does not work I think this patch should made it into 6.2.
  16. Stefan Neufeind commented on patch set 3 V -1 11/14/13, 20:18

    Stefan meant: The testsuite Core\Widget\AbstractWidgetControllerTest fails in viewConfigurationCanBeOverriddenThroughFrameworkConfiguration. That's because the inject in RenderingContext for $viewHelperVariableContainer does not work for some reason. Call to a member function setView() on a non-object in .../typo3/sysext/fluid/Classes/View/AbstractTemplateView.php on line 93
  17. Stefan Neufeind commented on patch set 3 V +1 11/14/13, 20:32

    It seems showstopper for me was some caching. Cleared all caches manually now just to be sure and it works now. I guess some cf_extbase_object or so might have been my problem. All (view) things I tested in the frontend also seemed to still work for me.
  18. Markus Klein commented on patch set 3 11/18/13, 23:09

    TemplateParserBuilder.php:32

    return it directly

    RenderingContext.php:61

    Why is this one preserved?
  19. Stefan Froemken commented on patch set 3 11/19/13, 08:24

    See comment

    RenderingContext.php:61 Reply

    It was called from some other classes directly.
  20. Markus Klein commented on patch set 3 V +2 CR +2 11/19/13, 09:48

    Clicked through the BE and fluid tests are running fine.
  21. Markus Klein merged patch set 4 11/19/13, 09:48