Review main Merged

23883[BUGFIX] Initialize extension name in command requests

Alexander Stehlik CR +2 V +2 Easy +32 −1 updated 09/28/13, 13:20

Commit message

This patch initializes the extension name in the configuration manager
as soon as it is available during an Extbase command line request.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 31

Show 6 earlier messages
  1. Mr. Jenkins commented on patch set 1 09/18/13, 08:04

  2. Alexander Stehlik uploaded patch set 2 09/18/13, 08:06

  3. Mr. Jenkins commented on patch set 2 09/18/13, 08:07

  4. Alexander Stehlik commented on patch set 2 09/18/13, 08:07

    Fixed related issue. Sorry for that!
  5. Georg Ringer commented on patch set 2 09/19/13, 06:03

    RequestBuilder.php:80

    guess the 2nd "now" should be a "know".
  6. Alexander Stehlik uploaded patch set 3 09/19/13, 07:02

  1. Alexander Stehlik commented on patch set 3 09/19/13, 07:03

    Two typos have been fixed.
  2. Mr. Jenkins commented on patch set 3 09/19/13, 07:23

  3. Arjen Hoekema voted on patch set 3 V +1 CR +1 09/20/13, 07:11

  4. Philipp Gampe commented on patch set 3 CR +1 09/21/13, 17:02

    I guess this should include 6.1 as the original issue refers to 6.1? Or did you exclude it by purpose?

    RequestBuilder.php:80

    For next patchset, please start the comment in Upper case (nitpick)
  5. Alexander Stehlik commented on patch set 3 09/22/13, 09:16

    Thanks for the feedback, updated version will be added in a minute.

    Reply

    You're right. The related scheduler issue was also considered as a bug so this should not be treated any different. I will add 6.1 and 6.0.
  6. Alexander Stehlik uploaded patch set 4 09/22/13, 09:20

  7. Mr. Jenkins commented on patch set 4 09/22/13, 09:30

  8. Arjen Hoekema commented on patch set 4 V +1 CR +1 09/23/13, 06:59

    Maybe the inline comment could be removed at all, it's pretty self-explanatory what the line of code does.
  9. Alexander Stehlik uploaded patch set 5 09/24/13, 12:01

  10. Alexander Stehlik commented on patch set 5 09/24/13, 12:01

    Removed comment as suggested by Arjen.
  11. Arjen Hoekema voted on patch set 5 V +1 CR +1 09/24/13, 12:02

  12. Mr. Jenkins commented on patch set 5 09/24/13, 12:11

  13. Georg Ringer commented on patch set 5 09/25/13, 06:13

    but shouldn't that be named extensionKey? or then at least adopt the commit message.
  14. Alexander Stehlik uploaded patch set 6 09/25/13, 06:41

  15. Alexander Stehlik commented on patch set 6 09/25/13, 06:42

    Changed commit message since it really is the extension name (upper camel case version) and not the extension key (lowercase underscored).
  16. Mr. Jenkins commented on patch set 6 09/25/13, 06:51

  17. Arjen Hoekema voted on patch set 6 V +1 CR +1 09/25/13, 07:22

  18. Georg Ringer voted on patch set 6 V +1 CR +1 09/25/13, 07:40

  19. Cedric Ziel voted on patch set 6 V +1 CR +1 09/26/13, 22:49

  20. Wouter Wolters commented on patch set 6 V -1 09/28/13, 12:17

    PHP Fatal error: Call to a member function setConfiguration() on a non-object in /var/www/websites/master/htdocs/typo3/sysext/extbase/Classes/Mvc/Cli/RequestBuilder.php on line 79
  21. Wouter Wolters uploaded patch set 7 09/28/13, 12:23

  22. Wouter Wolters voted on patch set 7 V +1 CR +1 09/28/13, 12:29

  23. Mr. Jenkins commented on patch set 7 09/28/13, 12:33

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 09/28/13, 13:20

  25. Anja Leichsenring merged patch set 8 09/28/13, 13:20