23883[BUGFIX] Initialize extension name in command requests
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
-
Verified V +2
- Anja Leichsenring +2
- Wouter Wolters +1
Issues 1
Files 3
Review log 31
Show 6 earlier messages
-
Mr. Jenkins commented on patch set 1 09/18/13, 08:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10798/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/10800/ : SUCCESS -
Alexander Stehlik uploaded patch set 2 09/18/13, 08:06
-
Mr. Jenkins commented on patch set 2 09/18/13, 08:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10799/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/10801/ : SUCCESS -
Alexander Stehlik commented on patch set 2 09/18/13, 08:07
Fixed related issue. Sorry for that! -
Georg Ringer commented on patch set 2 09/19/13, 06:03
RequestBuilder.php:80guess the 2nd "now" should be a "know". -
Alexander Stehlik uploaded patch set 3 09/19/13, 07:02
-
Alexander Stehlik commented on patch set 3 09/19/13, 07:03
Two typos have been fixed. -
Mr. Jenkins commented on patch set 3 09/19/13, 07:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10837/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/10837/ : SUCCESS -
Arjen Hoekema voted on patch set 3 V +1 CR +1 09/20/13, 07:11
-
Philipp Gampe commented on patch set 3 CR +1 09/21/13, 17:02
I guess this should include 6.1 as the original issue refers to 6.1? Or did you exclude it by purpose?RequestBuilder.php:80For next patchset, please start the comment in Upper case (nitpick) -
Alexander Stehlik commented on patch set 3 09/22/13, 09:16
Thanks for the feedback, updated version will be added in a minute.Reply
You're right. The related scheduler issue was also considered as a bug so this should not be treated any different. I will add 6.1 and 6.0. -
Alexander Stehlik uploaded patch set 4 09/22/13, 09:20
-
Mr. Jenkins commented on patch set 4 09/22/13, 09:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10869/ : SUCCESS -
Arjen Hoekema commented on patch set 4 V +1 CR +1 09/23/13, 06:59
Maybe the inline comment could be removed at all, it's pretty self-explanatory what the line of code does. -
Alexander Stehlik uploaded patch set 5 09/24/13, 12:01
-
Alexander Stehlik commented on patch set 5 09/24/13, 12:01
Removed comment as suggested by Arjen. -
Arjen Hoekema voted on patch set 5 V +1 CR +1 09/24/13, 12:02
-
Mr. Jenkins commented on patch set 5 09/24/13, 12:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10903/ : SUCCESS -
Georg Ringer commented on patch set 5 09/25/13, 06:13
but shouldn't that be named extensionKey? or then at least adopt the commit message. -
Alexander Stehlik uploaded patch set 6 09/25/13, 06:41
-
Alexander Stehlik commented on patch set 6 09/25/13, 06:42
Changed commit message since it really is the extension name (upper camel case version) and not the extension key (lowercase underscored). -
Mr. Jenkins commented on patch set 6 09/25/13, 06:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10909/ : SUCCESS -
Arjen Hoekema voted on patch set 6 V +1 CR +1 09/25/13, 07:22
-
Georg Ringer voted on patch set 6 V +1 CR +1 09/25/13, 07:40
-
Cedric Ziel voted on patch set 6 V +1 CR +1 09/26/13, 22:49
-
Wouter Wolters commented on patch set 6 V -1 09/28/13, 12:17
PHP Fatal error: Call to a member function setConfiguration() on a non-object in /var/www/websites/master/htdocs/typo3/sysext/extbase/Classes/Mvc/Cli/RequestBuilder.php on line 79 -
Wouter Wolters uploaded patch set 7 09/28/13, 12:23
-
Wouter Wolters voted on patch set 7 V +1 CR +1 09/28/13, 12:29
-
Mr. Jenkins commented on patch set 7 09/28/13, 12:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10981/ : SUCCESS -
Anja Leichsenring voted on patch set 7 V +2 CR +2 09/28/13, 13:20
-
Anja Leichsenring merged patch set 8 09/28/13, 13:20